Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1575133imm; Sat, 4 Aug 2018 06:20:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdaljax3nhRKp2PEuJqoUBi6K6ldPYqKn3WQpAQ/uhBhNdYlgBYQ3PfE5q7jR4/1St/TYDv X-Received: by 2002:a17:902:aa83:: with SMTP id d3-v6mr7326693plr.242.1533388848872; Sat, 04 Aug 2018 06:20:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533388848; cv=none; d=google.com; s=arc-20160816; b=A/u+Jat+l5+V2vB/dkm5CKxRaV0EPclqXUuRK9MzmBKXTI/tNKGN3odgT0LEjmJ5S2 WmNiO1wzmMpG5gdVtVa1U/X6QxMkKZR42O8mJSdKzvLfk/bPRbmVtDspaFGAPaoLDjX2 m2YfhSkteH1Bw5WwkYsaCPu12TieQYC8KJFfPe5NSfDtU7FZXco8yAxTr37uFofbVzX1 m/syEupkIXO0ghOocSzTiT5hduIdQik7ywDYMunNIFc/u+cFILqnty6bZnGPcoDj4c64 23H/Pqg/VXsJG/YVxEdH9YVft/tNcwTYPhMmPeSxlW3HlxtvuXuXOA42AWp2fke3Pztw KYjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :references:subject:cc:to:mime-version:user-agent:from:date :message-id:arc-authentication-results; bh=PyqWQL+4BXOGW+lnX1yJ2An2Ts41x4pRXL2tJgy57Fw=; b=hLlXNPSr8C7tsUGiUY0jW874XOdudTZfSCthw8BspXS0eV7VsYLiO5Akyz3ecNZXGY /tYByN9gnROTRjhTUxq42xjQTyRsbRnRyafEBwoucSXWgvzSplHO/qu8x1Q7RJrqfqze otdAoldT2SUbBqWw24DTIabcEUnc40/qYHUbVeF5y0J9KgTecOOndj4xTZxV2KeLYfYa 59WuzhAoI/sdMWrm3inzp5L2nwZ+JRzZwsrAYkffWWVNUSC6HnE4he+0ElPH/eUKvglg 4Feq64P+g/ShK5PQLxLWSKe8l5zpF+kp6jBl9a12QA21rpjxLKDASfDKAUDd9CMBYBE3 j2RQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6-v6si7513343pgm.644.2018.08.04.06.20.34; Sat, 04 Aug 2018 06:20:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729689AbeHDPU1 (ORCPT + 99 others); Sat, 4 Aug 2018 11:20:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10225 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726871AbeHDPU1 (ORCPT ); Sat, 4 Aug 2018 11:20:27 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 78745C5D3A798; Sat, 4 Aug 2018 21:19:40 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.399.0; Sat, 4 Aug 2018 21:19:39 +0800 Message-ID: <5B65A7E9.90607@huawei.com> Date: Sat, 4 Aug 2018 21:19:37 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Lu Fengqi CC: , , , , Subject: Re: [PATCH] btrfs/extent_map: Remove unneeded variable "ret" References: <1533381223-16734-1-git-send-email-zhongjiang@huawei.com> <20180804125947.GF2049@fnst.localdomain> In-Reply-To: <20180804125947.GF2049@fnst.localdomain> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/8/4 20:59, Lu Fengqi wrote: > On Sat, Aug 04, 2018 at 07:13:43PM +0800, zhong jiang wrote: >> The ret is not used after initalization, So just remove it. > So why not change these two functions to void function? > I just keep the original interface and make the minimal change. of course, It is also feasible that make these two functions to void function. I will repost if you prefer to that change. I am ok with that. Thanks, zhong jiang