Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1640991imm; Sat, 4 Aug 2018 07:39:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc0hpG1Bt7nQQrxWLR7er8b3GzzpKkjeMRcE1u8s3lGS7E9M/bj6lGZ8wksHvBfmC3EkvYY X-Received: by 2002:a17:902:74c2:: with SMTP id f2-v6mr7452208plt.260.1533393589362; Sat, 04 Aug 2018 07:39:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533393589; cv=none; d=google.com; s=arc-20160816; b=Y6gjHwsiePJQPMqFRqEXL5jBDpw0IBPCiv/qE3+1bMQ9U0yv5TZoa7YmDzlopmZftF 0onRNc5SoSanx+5wJQF0BEZRQReEGHOcs/ZJY/ItnHt7tFPNtrPpVrd7+MRVeQs3vMT3 qHsA13EjSCHy3IvrMIGF6xXueV/pQxozeQfHxZOW8HZUJ35ZHL1iIoP2Zt4q/MCUgggY cxlZFQ+zrYhcUHAFs3KoMhdeOrZ2EgG4/t071amr/5BXty7QR9xMDllo+TEJeGuIplS/ 2cCXFWHOCjre+lFdthZ5tOcjk/FqVhCIiZ5le3i6h4RMXHxshD7Eh4rtCJa7XOGIHWQK 0UJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=Y2jvmsZGUnH2Ro5MHcHnEGvxDfLsk23kqFM4tBiJ92g=; b=swHNUXr1GirXduvy7y5Vfgyog00RTOkNE3eD0yNRR0gu1F7XmtTYGX/BL4PERdjKjb xupwmy3AI3BcaQz4EVYW8yCMt1RY6HZribgiyfEK+UUHQScGxcmn8sUTqyDznW24967A 4EB/QWoO6vIRp9w85B6Mh/oXU8DBUdBKcjKwrgpMLZKgsKFueOxXnDRyfJG4ZHuHmZyI EIL3vj15GisGpzncYzQ2zHQUtU3zsQW68zEv6uS6RZ+FZBgI9gYWj71+nKCTwug/a8F3 ht6Y3NKdAdtaHbe7tvVLeNjsURP+6dKR8obW2XUMMrC/izoum+Sv9P2ePkmb1AgKTp3c fxTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m193-v6si8238636pfc.312.2018.08.04.07.39.34; Sat, 04 Aug 2018 07:39:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731280AbeHDQhg (ORCPT + 99 others); Sat, 4 Aug 2018 12:37:36 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50595 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727600AbeHDQhg (ORCPT ); Sat, 4 Aug 2018 12:37:36 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3674FFB9985D; Sat, 4 Aug 2018 22:36:39 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.399.0; Sat, 4 Aug 2018 22:36:38 +0800 From: zhong jiang To: CC: , , , Subject: [PATCH] powpc:feature: of_node_put is not needed after iterator. Date: Sat, 4 Aug 2018 22:25:00 +0800 Message-ID: <1533392700-24621-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org for_each_node_by_name iterators only exit normally when the loop cursor is NULL, So there is no point to call of_node_put. Signed-off-by: zhong jiang --- arch/powerpc/platforms/powermac/feature.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c index 3f82cb2..4eb8cb3 100644 --- a/arch/powerpc/platforms/powermac/feature.c +++ b/arch/powerpc/platforms/powermac/feature.c @@ -2889,10 +2889,8 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ /* On all machines, switch modem & serial ports off */ for_each_node_by_name(np, "ch-a") initial_serial_shutdown(np); - of_node_put(np); for_each_node_by_name(np, "ch-b") initial_serial_shutdown(np); - of_node_put(np); } void __init -- 1.7.12.4