Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 04 Aug 2018 13:08:33 -0700 (PDT)
Message-Id: <20180804.130833.571423391959893455.davem@davemloft.net>
To:     baijiaju1990@gmail.com
Cc:     benve@cisco.com, _govind@gmx.com, pkaustub@cisco.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180804004009.18928-1-baijiaju1990@gmail.com>
References: <20180804004009.18928-1-baijiaju1990@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Sat,  4 Aug 2018 08:40:09 +0800

> vnic_dev_register(), vnic_rq_alloc_bufs() and vnic_wq_alloc_bufs() 
> are never called in atomic context.
> They call kzalloc() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied to net-next, thanks.