Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1901210imm; Sat, 4 Aug 2018 13:33:02 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfeC81i8NLm4Z5qLxwOano/AOlhqGvg5GjlA93RvcGFhpPSpH8FGhTpKac4FovbqDK/BDxS X-Received: by 2002:a17:902:925:: with SMTP id 34-v6mr8501664plm.103.1533414782145; Sat, 04 Aug 2018 13:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533414782; cv=none; d=google.com; s=arc-20160816; b=JQTlsfjU6tiTfJ/iBOCqkH5n+ZgSkP5sojxvo1/8xG0PJIBnN/8z7z/MSPxwOZJSxB qTxbZ+q3a+qDD+erfk5Zn8yhSJuA/jCLPCbIaYmHPj5E8980hYXVBGIUL4Gj/giFiddf MWs4kF7CdgptW+FgpkpFttOwl/yAuSuyrHbNzIZQCXSRt/SY5yAyO2CWkdQ1BpM8b4Jk SsDJJqZwzbbS6VcOKvPPSWp7LBtdWV2Xtqr9AVN/mPFO3PDEIIxtrmcDWAi748uSgaoN WWgvmr3lElh415VuxYI33axIBMJ4PmieONmrFSz9uszxuKonIIJOyV2CXkikQnb3WHtn 0AsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language:in-reply-to:mime-version :user-agent:date:message-id:openpgp:from:references:cc:to:subject :arc-authentication-results; bh=y9aiYseVmFSrjGpBvjZ88Ou54mfcvbMeVykCvkqhXhk=; b=iJbw3U/xF1uzDiwgHXXtKnK/5LeIQ6jI1XxJdXxQwDKdLoUYJtVO609DejoB+/HQj6 FK1sX8RE3CAknTY2zIWgUQfiuuSCPh//JX9lHoPob034GrcUgf8YrtwUL8grenqZkYjm hvC5Fgy1GJxiaOoMUczszkGRIG4uatFb4r/Jtr8h7ctTq6KrzuwDeiB39NZdsWiQ+AdP rFjQ0nnzbrsh5aIKv/aVVBxDhK7col1SqWDzv6V2yOLu7b1QOG2LMb6WpEeHSjnAfRL6 JYzSBF9YQ0hi795YxJ6yQkqoC1YDPAVJiQMksvTqPOos9KZQ5RNZ+6UdqM6i0JSJITtQ fbJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e34-v6si6717908plb.2.2018.08.04.13.32.45; Sat, 04 Aug 2018 13:33:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729678AbeHDWdo (ORCPT + 99 others); Sat, 4 Aug 2018 18:33:44 -0400 Received: from forward105j.mail.yandex.net ([5.45.198.248]:37915 "EHLO forward105j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727127AbeHDWdo (ORCPT ); Sat, 4 Aug 2018 18:33:44 -0400 Received: from mxback1j.mail.yandex.net (mxback1j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10a]) by forward105j.mail.yandex.net (Yandex) with ESMTP id 41D081852E7; Sat, 4 Aug 2018 23:31:48 +0300 (MSK) Received: from smtp2o.mail.yandex.net (smtp2o.mail.yandex.net [2a02:6b8:0:1a2d::26]) by mxback1j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id iOrIcDulVX-VlWWuZOr; Sat, 04 Aug 2018 23:31:48 +0300 Received: by smtp2o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id kiRpq2KbQV-VkamrckE; Sat, 04 Aug 2018 23:31:46 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: Re: LVM snapshot broke between 4.14 and 4.16 To: Linus Torvalds Cc: Mike Snitzer , Theodore Ts'o , Jens Axboe , Sagi Grimberg , Linux Kernel Mailing List , linux-block , dm-devel@redhat.com, Ilya Dryomov , Zdenek Kabelac References: <1ec0a220-d5b0-1c27-e63b-c4d3f4ce9d77@torlan.ru> <20180803133102.GA3092@redhat.com> <20180803152034.GD32066@thunk.org> <20180803183932.GA3258@redhat.com> <20180803190617.GA4498@redhat.com> From: WGH Openpgp: preference=signencrypt Message-ID: Date: Sat, 4 Aug 2018 23:29:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------08D3D26552869C678A565F6E" Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------08D3D26552869C678A565F6E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/04/2018 08:04 PM, Linus Torvalds wrote: > Anyway, just out of curiosity, what was the traceback? > > I'm not entirely happy with that patch either (even after the obvious > fix to add the "1" argument), but it does seem like the minimal > temporary workaround for now. Here it is. --------------08D3D26552869C678A565F6E Content-Type: text/x-log; name="traceback.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="traceback.log" [ 68.313024] ------------[ cut here ]------------ [ 68.313030] dm-3 [ 68.313049] WARNING: CPU: 1 PID: 77 at block/blk-core.c:2180 generic_make_request_checks+0x4ac/0x600 [ 68.313054] Modules linked in: nf_tables xt_cgroup xt_owner kvm_intel iwlmvm kvm irqbypass iwlwifi [ 68.313068] CPU: 1 PID: 77 Comm: kworker/1:1 Not tainted 4.17.9-gentoo #3 [ 68.313071] Hardware name: LENOVO 20B6A019RT/20B6A019RT, BIOS GJET91WW (2.41 ) 09/21/2016 [ 68.313077] Workqueue: ksnaphd do_metadata [ 68.313083] RIP: 0010:generic_make_request_checks+0x4ac/0x600 [ 68.313087] RSP: 0018:ffffc900002e7ba8 EFLAGS: 00010282 [ 68.313091] RAX: 0000000000000000 RBX: ffff8801ef6da300 RCX: ffffffff82636218 [ 68.313094] RDX: 0000000000000001 RSI: 0000000000000086 RDI: ffffffff82cf57cc [ 68.313097] RBP: ffff880211c2b150 R08: 0000000000000004 R09: 0000000000000307 [ 68.313100] R10: ffffc900002e7c80 R11: ffffffff82cf780d R12: 0000000000000000 [ 68.313103] R13: 0000000000000001 R14: 0000000000001000 R15: ffff8801ef6da300 [ 68.313107] FS: 0000000000000000(0000) GS:ffff88021f240000(0000) knlGS:0000000000000000 [ 68.313111] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 68.313114] CR2: 000056166d9e8520 CR3: 0000000003a0a006 CR4: 00000000001606e0 [ 68.313117] Call Trace: [ 68.313126] ? scsi_init_sgtable+0x42/0x80 [ 68.313134] ? kmem_cache_alloc+0x170/0x1a0 [ 68.313140] generic_make_request+0x64/0x400 [ 68.313146] ? submit_bio+0x6c/0x140 [ 68.313150] ? bio_alloc_bioset+0xa9/0x1f0 [ 68.313155] submit_bio+0x6c/0x140 [ 68.313160] ? vm_get_page+0x20/0x50 [ 68.313165] dispatch_io+0x287/0x430 [ 68.313171] ? bio_next_page+0xb0/0xb0 [ 68.313175] ? bio_get_page+0x40/0x40 [ 68.313180] ? cpumask_next+0x16/0x20 [ 68.313185] sync_io+0xc3/0x120 [ 68.313191] dm_io+0x1f8/0x220 [ 68.313196] ? bio_next_page+0xb0/0xb0 [ 68.313200] ? bio_get_page+0x40/0x40 [ 68.313204] ? cpumask_next+0x16/0x20 [ 68.313209] do_metadata+0x1d/0x30 [ 68.313216] process_one_work+0x1b9/0x3e0 [ 68.313222] worker_thread+0x2b/0x3c0 [ 68.313227] ? wq_update_unbound_numa+0x10/0x10 [ 68.313232] kthread+0x113/0x130 [ 68.313237] ? kthread_create_worker_on_cpu+0x70/0x70 [ 68.313242] ret_from_fork+0x35/0x40 [ 68.313246] Code: 3e fc ff ff 45 8b a4 24 4c 03 00 00 48 8d 74 24 08 48 89 df c6 05 3a 49 35 01 01 e8 df 68 01 00 48 89 c7 44 89 e6 e8 c4 a0 cd ff <0f> 0b 4c 8b 63 08 e9 0c fc ff ff 80 3d 18 49 35 01 00 0f 85 29 [ 68.313300] ---[ end trace 2a4da4181ebee969 ]--- --------------08D3D26552869C678A565F6E--