Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1533422007.2679.141.camel@arista.com>
Subject: Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent
 groups
From:   Dmitry Safonov <dima@arista.com>
To:     Nathan Chancellor <natechancellor@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        netdev@vger.kernel.org
Date:   Sat, 04 Aug 2018 23:33:27 +0100
In-Reply-To: <20180804180734.GA25546@flashbox>
References: <20180804082702.434482435@linuxfoundation.org>
         <20180804082706.427556290@linuxfoundation.org>
         <20180804180734.GA25546@flashbox>
Content-Type: multipart/mixed; boundary="=-zKF9eMMdzTtDJf+QczBV"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-zKF9eMMdzTtDJf+QczBV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Sat, 2018-08-04 at 11:07 -0700, Nathan Chancellor wrote:
> Hi Greg,

Hi Nathan,

> I am so sorry I didn't catch this in my initial report but this
> commit
> along with ba7aaf93ef2f ("netlink: Don't shift with UB on nlk-
> >ngroups")
> breaks mobile data on both the Pixel 2 XL and OnePlus 6. There is
> signal
> but it just never connects to 3G/LTE. Reverting those two commits
> fixes
> the issue.

Sorry for breaking your use-case,

> Nothing stands out to me in dmesg unfortunately and iven neither
> device
> is running a vanilla kernel, I cannot say if this is a problem in
> mainline
> or not but I just wanted to make you aware of it.

Could you provide the dmesg output for the attached debug diff?

-- 
Thanks,
             Dmitry
--=-zKF9eMMdzTtDJf+QczBV
Content-Disposition: attachment; filename="netlink_groups.diff"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch; name="netlink_groups.diff"; charset="UTF-8"

ZGlmZiAtLWdpdCBhL25ldC9uZXRsaW5rL2FmX25ldGxpbmsuYyBiL25ldC9uZXRsaW5rL2FmX25l
dGxpbmsuYwppbmRleCA3ZDg2MGEyMmU1ZmIuLjBjZGRjMzVlMWU4NyAxMDA2NDQKLS0tIGEvbmV0
L25ldGxpbmsvYWZfbmV0bGluay5jCisrKyBiL25ldC9uZXRsaW5rL2FmX25ldGxpbmsuYwpAQCAt
MTAwOSwxMCArMTAwOSwxNCBAQCBzdGF0aWMgaW50IG5ldGxpbmtfYmluZChzdHJ1Y3Qgc29ja2V0
ICpzb2NrLCBzdHJ1Y3Qgc29ja2FkZHIgKmFkZHIsCiAJCQlyZXR1cm4gZXJyOwogCX0KIAotCWlm
IChubGstPm5ncm91cHMgPT0gMCkKKwlpZiAobmxrLT5uZ3JvdXBzID09IDApIHsKIAkJZ3JvdXBz
ID0gMDsKLQllbHNlCisJfSBlbHNlIHsKKwkJaWYgKGdyb3VwcyAhPSAoZ3JvdXBzICYgKCgxVUxM
IDw8IG5say0+bmdyb3VwcykgLSAxKSkpCisJCQlwcl9hbGVydCgiJXM6IGdyb3VwczogJSNseCBu
Z3JvdXBzOiAldVxuIiwKKwkJCQljdXJyZW50LT5jb21tLCBncm91cHMsIG5say0+bmdyb3Vwcyk7
CiAJCWdyb3VwcyAmPSAoMVVMTCA8PCBubGstPm5ncm91cHMpIC0gMTsKKwl9CiAKIAlib3VuZCA9
IG5say0+Ym91bmQ7CiAJaWYgKGJvdW5kKSB7Cg==


--=-zKF9eMMdzTtDJf+QczBV--