Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1533426425.2679.154.camel@arista.com>
Subject: Re: [PATCH 4.4 106/124] netlink: Do not subscribe to non-existent
 groups
From:   Dmitry Safonov <dima@arista.com>
To:     David Miller <davem@davemloft.net>
Cc:     natechancellor@gmail.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        herbert@gondor.apana.org.au, steffen.klassert@secunet.com,
        netdev@vger.kernel.org
Date:   Sun, 05 Aug 2018 00:47:05 +0100
In-Reply-To: <20180804.163348.896647113172060665.davem@davemloft.net>
References: <1533424322.2679.144.camel@arista.com>
         <20180804232102.GA3982@flashbox> <1533425198.2679.148.camel@arista.com>
         <20180804.163348.896647113172060665.davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2018-08-04 at 16:33 -0700, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Sun, 05 Aug 2018 00:26:38 +0100
> 
> > Thanks for the testing, sorry again for the breakage.
> > Will send the patch shortly (with sizeof(unsigned long long)
> instead of
> > hard-coded 64). Hopefully, not too late.
> 
> 'groups' is "long unsigned int" not "unsigned long long"
> 
>         long unsigned int groups = nladdr->nl_groups;
> 
> And nladdr->nl_groups is specified as "__u32"
> 
> So the size of the relevant bits is actually strictly 32-bit.
> 
> This makes also the "ULL" in your constant specification incorrect as
> well.

I think, ULL is right - I did it to make shift for 32 well-defined.
(which in result has 32 bits set)

> 
> So much crazy stuff going on here :-/