Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2036957imm; Sat, 4 Aug 2018 17:28:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfO9aeT1B/+T5BmShgJ2Gw7wP6nyTLDcLGX5W8KnEPQ5vr4ZMBAlFuPWTayiShAxG2oRQP5 X-Received: by 2002:a63:2404:: with SMTP id k4-v6mr9074388pgk.191.1533428933218; Sat, 04 Aug 2018 17:28:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533428933; cv=none; d=google.com; s=arc-20160816; b=Ll/VJccIjCh/9+qf90F1cHWGVJxFsYKDCHCftXkT/5aIUgii+l76slYI7k4iHOpuQ1 oBrCAkSOpSRHm2Tdn1TVEIySeCq+p1wbWWRpfqbsnSt04imiokEAKZusaeQq+wXCaRuo DnLSKfvCEzz6nFZf/Cv11MJ66cxjKNIOFL0NVbPbkJkMR6c3xBIHAvTEc4e7GEUoveBC aMjH76E+6czG8DjTbnzsD36t70oOQehoRSShCLr90byjD7IF3OA/WZZRllj7eGyMVydQ mnL5HR6oWpcLksdi1L0bpJ+g6iGsrfM7NDk2apXjrcBFkypZO9/AgqdFHvGTz6YK1BmC d92g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=vzmBvuYq6C3RZO7pu6jyri03mrnd4uEnkuVVSBV6iAw=; b=V01lKXastNidDjzvZy6s4u98y5Gv5Av7aDgktcxaW5t9Wf51EbQybQEl5KVPdQebY0 1/C6XFZSmQicaSn/OYojgTwUCmlriB2xV5sjFGDc6odeTzS+Ez5eeq7ZHzLTnH0YH9yZ Ee2v4MM6lu3Ivd2g+aRU4jfagwinhiSCKfpUSoqmEqiQIHswQRLNbOsIPUFldBY1QGf7 LNEeEsqJyAsA1cEeQ6G1nwKDL8I9cm1CG0O5rsQufBANQwuk491UBiBTkSRsZmDqyoUP afsgB1byOAKMLV8mWHZxFc7Rh5t/JOLQrHHV1bg/UlygRHzCSisQkLSCeLHdrJ49Hxv1 9RpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12-v6si6401143plz.105.2018.08.04.17.28.38; Sat, 04 Aug 2018 17:28:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729983AbeHEC3e (ORCPT + 99 others); Sat, 4 Aug 2018 22:29:34 -0400 Received: from gateway33.websitewelcome.com ([192.185.145.190]:13455 "EHLO gateway33.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbeHEC3e (ORCPT ); Sat, 4 Aug 2018 22:29:34 -0400 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 62DE6C27D3 for ; Sat, 4 Aug 2018 19:27:04 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id m6syfdcL0kBj6m6syfw4ES; Sat, 04 Aug 2018 19:27:04 -0500 X-Authority-Reason: nr=8 Received: from [189.250.50.82] (port=35062 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fm6sx-003f3t-Oe; Sat, 04 Aug 2018 19:27:03 -0500 Date: Sat, 4 Aug 2018 19:27:02 -0500 From: "Gustavo A. R. Silva" To: Oded Gabbay , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] drm/amdkfd: Use true and false for boolean values Message-ID: <20180805002702.GA26671@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.50.82 X-Source-L: No X-Exim-ID: 1fm6sx-003f3t-Oe X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.50.82]:35062 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 41 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c index 5d2475d..16af9d1 100644 --- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c +++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c @@ -62,12 +62,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev, vmid = (ihre->ring_id & 0x0000ff00) >> 8; if (vmid < dev->vm_info.first_vmid_kfd || vmid > dev->vm_info.last_vmid_kfd) - return 0; + return false; /* If there is no valid PASID, it's likely a firmware bug */ pasid = (ihre->ring_id & 0xffff0000) >> 16; if (WARN_ONCE(pasid == 0, "FW bug: No PASID in KFD interrupt")) - return 0; + return false; /* Interrupt types we care about: various signals and faults. * They will be forwarded to a work queue (see below). -- 2.7.4