Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2039456imm; Sat, 4 Aug 2018 17:33:09 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfVZsdpvLaesxIY9txzGXFZ7uLh6TmeY1s27bzBZ5nq1WREhIK2E2v2+mArTW+L6dQy7/4C X-Received: by 2002:a63:1f20:: with SMTP id f32-v6mr8927889pgf.84.1533429189009; Sat, 04 Aug 2018 17:33:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533429188; cv=none; d=google.com; s=arc-20160816; b=Gx4dGQhPsW7FBeR0vVzeMige6M/111O7RvTkYsp2JQwp8QBY+3bPeOoGLZeM3uh+Dl CQ+YdaFnTHcwr0X/Qy0MS/8Y7O9fKrznyPrY+zBJUPhy6VJdfKH+9y+7WJUP8QpcBwT4 XH7YGpSqUz3tWY0ozfU0aJpUkjp5GFf3mqnbFAnUdbi8i3xO17Wc/8OSeJv0FRF5107d CDnDyv74CLzNiSfSkmyDFQ3MDvhv5Pj8E3sE7nXaK3a1W0xMHq8lOL7cBlAcR6JNFjm9 5m6BD/T9MZT6i1GOUDqXmzF7Kewsv/UeRa1Y9vzh/rwjV55cG9mnBnEad9QK/StVYYaw zmjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=ZYx165DZXaH6Cdz3ZMnO8EM6BEHwtZN5OW71rRaglC0=; b=tROVIvWdZ/nymVPICDKy9ZuJ+MXnkY1jntc017a0fNX3RYND8uA2CDgVlghQn6LF4D z8yEb0ENx286AdMGQkJCUOduVoIT3t9KNRUuKSCDQ7x2cGdNBv0rKiu0/elP8lXJZXLH KQSvTP0Gg4dk64IFhT2ox2QtmKrImM+1mTNlDGQ7MYUhpoI8CBJgTDrlr9r7Xvzmv4eO 7+/R98cIlXBVKmozlTdWkqX4dQMyIbhf6/cz04lYwhZ2/tpj+IBv/DJOlWG/CQU3dMBB 46WhkZI3gY3ws7NtuLWJlmbSgxbfEj0w3ywq1+QR1hEUm5ZDKKm+eq6Ax2NrOTzEYxzs icjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si7092162pgp.551.2018.08.04.17.32.54; Sat, 04 Aug 2018 17:33:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbeHECeh (ORCPT + 99 others); Sat, 4 Aug 2018 22:34:37 -0400 Received: from gateway30.websitewelcome.com ([192.185.197.25]:41276 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbeHECeh (ORCPT ); Sat, 4 Aug 2018 22:34:37 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway30.websitewelcome.com (Postfix) with ESMTP id EDD3B44B5 for ; Sat, 4 Aug 2018 19:09:02 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id m6bWf67AebXuJm6bWfVccs; Sat, 04 Aug 2018 19:09:02 -0500 X-Authority-Reason: nr=8 Received: from [189.250.50.82] (port=34986 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fm6bV-003YLZ-2h; Sat, 04 Aug 2018 19:09:01 -0500 Date: Sat, 4 Aug 2018 19:08:59 -0500 From: "Gustavo A. R. Silva" To: Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Boris Ostrovsky , Juergen Gross , Jens Axboe Cc: xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] xen-blkfront: use true and false for boolean values Message-ID: <20180805000859.GA20132@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.50.82 X-Source-L: No X-Exim-ID: 1fm6bV-003YLZ-2h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.50.82]:34986 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 15 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 94300db..8986ada 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1436,7 +1436,7 @@ static bool blkif_completion(unsigned long *id, /* Wait the second response if not yet here. */ if (s2->status == REQ_WAITING) - return 0; + return false; bret->status = blkif_get_final_status(s->status, s2->status); @@ -1537,7 +1537,7 @@ static bool blkif_completion(unsigned long *id, } } - return 1; + return true; } static irqreturn_t blkif_interrupt(int irq, void *dev_id) -- 2.7.4