Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <0d4090532f15434aa71779e9dc8a0014@BJSGEXMBX10.didichuxing.com>
In-Reply-To: <0d4090532f15434aa71779e9dc8a0014@BJSGEXMBX10.didichuxing.com>
From:   =?UTF-8?B?56a56Iif6ZSu?= <ufo19890607@gmail.com>
Date:   Sun, 5 Aug 2018 11:41:50 +0800
Message-ID: <CAHCio2idn3oh55n7urkRPqkdyo+Y-0Qhg=Vc2VHXy2Wy2q1wiA@mail.gmail.com>
Subject: Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d
To:     Wind Yu <yuzhoujian@didichuxing.com>
Cc:     mhocko@kernel.org, rientjes@google.com, rong.a.chen@intel.com,
        sfr@canb.auug.org.au, kirill.shutemov@linux.intel.com,
        aarcange@redhat.com, penguin-kernel@i-love.sakura.ne.jp,
        guro@fb.com, yang.s@alibaba-inc.com, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, lkp@01.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Michal and David,
AFAICS, the null pointer is the task_struct of p in the dump_header.
Why don't we just add a if before printing the victim task's
informaiton.

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -438,14 +438,6 @@ static void dump_header(struct oom_control *oc,
struct task_struct *p)

        cpuset_print_current_mems_allowed();
        mem_cgroup_print_oom_context(oc->memcg, p);
-       pr_cont(",task=%s,pid=%d,uid=%d\n", p->comm, p->pid,
-               from_kuid(&init_user_ns, task_uid(p)));
+      if (p)
+              pr_cont(",task=%s,pid=%d,uid=%d", p->comm, p->pid,
+                      from_kuid(&init_user_ns, task_uid(p)));
+     pr_cont("\n");
        if (is_memcg_oom(oc))
                mem_cgroup_print_oom_meminfo(oc->memcg);

Thanks
Zhoujian