Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2160826imm; Sat, 4 Aug 2018 21:16:06 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd5sTiA1hNV3AJHvXH3lNRpBsooJJJ8nz+57DY2Qcbqm9uI9G/iBV3g7eMVmZgT/CBijYbP X-Received: by 2002:a17:902:8494:: with SMTP id c20-v6mr9195536plo.336.1533442566202; Sat, 04 Aug 2018 21:16:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533442566; cv=none; d=google.com; s=arc-20160816; b=W0GlZkj0H0+bbGDBjvR+lgh92DLPuLwWnfCcR8RhzoxXwaiVa5Ue/LEVqs+jWF3UEB 9lg+sCdZwy/oftLJhsbA8ILJZSCQfpWMciDf4uzWnReeCoCL1/M39Co0YRWUZ5KjNDxY 8yEUyyCxODtG7D0co6oEzgUx5eDMcGuMM53uWaOHxzPFm1AROyAmcO45BgKnyxrmH0mk YUFrmrEKUPzTpl9rof3wb8sic4RSWs3XK+p16cB6T1jh1qJlkwS9efQ6Zd2fOdU4Wo3V qb+TAxs1+uIl/HB3dDd7qHnC8jbd72GP1t4/00eMR0VdbNqoz7uBLqWjrkkogWUWoFno rGOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=anN5xI7OT65e3JAucy3Iy7UyJD5iDtf6ZtFH72LM1xw=; b=qMTNRVXOFvXnj+NEo+jMQAGrqXmn/W0FPqi3LbpcphTIIIt/xJtmbI+sU2ADXKWZtr qPQjLnXXrLM+ol0U/6esXJmhA+TDekK7kQRjlfkK8VnoDtXcFNpErrfr6QLY3jWytdL8 vcNF1JMpdImYCqLYlL6wRzWvJDwrtsPR86AdnCjtithyqcBpmJz5azXvOyVs9Y9FSXmm sOOtzV5O60tCvURRiANdtbJsMXqAwmNcGY2XGhjXmmDpmgnz7e0Ilzv4NxkQYN3Y9Zdc rMGVoGtZRvspYVd05zhGMXGy1a6qhkFqmoxy/4kDde7BYY+oxANsdRRz0j1/BpRArNA8 MT3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x68-v6si9785875pfc.239.2018.08.04.21.15.50; Sat, 04 Aug 2018 21:16:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726180AbeHEGSH (ORCPT + 99 others); Sun, 5 Aug 2018 02:18:07 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.189]:20503 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbeHEGSH (ORCPT ); Sun, 5 Aug 2018 02:18:07 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id E41A56AADB for ; Sat, 4 Aug 2018 23:14:58 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id mARWfu3ORaSeymARWfSe7q; Sat, 04 Aug 2018 23:14:58 -0500 X-Authority-Reason: nr=8 Received: from [189.250.50.82] (port=39900 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fmARV-000b7j-U6; Sat, 04 Aug 2018 23:14:58 -0500 Date: Sat, 4 Aug 2018 23:14:54 -0500 From: "Gustavo A. R. Silva" To: Jason Wessel , Daniel Thompson Cc: kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] kdb: kdb_main: mark expected switch fall-throughs Message-ID: <20180805041454.GA18449@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.50.82 X-Source-L: No X-Exim-ID: 1fmARV-000b7j-U6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.50.82]:39900 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115090 ("Missing break in switch") Addresses-Coverity-ID: 115091 ("Missing break in switch") Addresses-Coverity-ID: 114700 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- kernel/debug/kdb/kdb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 2ddfce8..2249645 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1545,13 +1545,16 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr, *c++ = printable_char(*cp++); *c++ = printable_char(*cp++); addr += 4; + /* fall through */ case 4: *c++ = printable_char(*cp++); *c++ = printable_char(*cp++); addr += 2; + /* fall through */ case 2: *c++ = printable_char(*cp++); addr++; + /* fall through */ case 1: *c++ = printable_char(*cp++); addr++; -- 2.7.4