Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5b2806ada98cfca4346e48f1943aca6da0cda4a6.camel@perches.com>
Subject: Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err"
From:   Joe Perches <joe@perches.com>
To:     zhong jiang <zhongjiang@huawei.com>, clm@fb.com, jbacik@fb.com,
        dsterba@suse.com
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Sun, 05 Aug 2018 08:27:49 -0700
In-Reply-To: <1533481371-21349-2-git-send-email-zhongjiang@huawei.com>
References: <1533481371-21349-1-git-send-email-zhongjiang@huawei.com>
         <1533481371-21349-2-git-send-email-zhongjiang@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote:
> The err is not used after initalization, So remove it and make
> the function to be void function.
[]
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
[]
> @@ -4193,7 +4192,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
>  	if (atomic_read(&delayed_refs->num_entries) == 0) {
>  		spin_unlock(&delayed_refs->lock);
>  		btrfs_info(fs_info, "delayed_refs has NO entry");
> -		return ret;

Think a little more about this please.
This is not a sensible removal.

>  	}
>  
>  	while ((node = rb_first(&delayed_refs->href_root)) != NULL) {