Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2750862imm; Sun, 5 Aug 2018 11:15:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpchEuZ1i/RzOmpaQUOiwW0LvTIwKBA5DOJ8aBUqbh4G2mcjTkJB/F2jVnnnO4lP/wovmTZw X-Received: by 2002:a63:6949:: with SMTP id e70-v6mr12024756pgc.119.1533492939246; Sun, 05 Aug 2018 11:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533492939; cv=none; d=google.com; s=arc-20160816; b=otxVstw7CeiFhKNJ9Y0C3bumSWwD4YTeskA1tb2YVRKXLq4AHKZD02x6Iqu6coDnyY bCsHz0fEDUfaYoJ+drTgP+E4PpSfYMfhZSxztW+kphZYdAyx93ss4JDrvG4xPXc9leiY KRHHMxfO1rTkwLIC8lXIM1XuMjpUcF74x5VKv+naLJvyfswnvedHlptljT7XV9WrCiSa UyHZ4kJRjBpSWB4YHBHbUljMynY46q5GIePJjWLlYVeer/CIlBgtjamlFokEdBzIjUKb Iiik1zordPd/DSIrPmiyZ20HkUmBaqwfwWeilrnXf8nVLS7Uy55sU9y8ekcenRgIpzfc NzmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=MNomvHJi8J7jCXkVzSaZQ0MyxHzyvtgYvZo1FPLDWBU=; b=aFR9CcYwrNZBYtZg+if0JTZAevRknLf0p5+euaftxtZI7b1MyvJvoDyiFcaGvzCECJ NSDj3Q0+0edkvc9xhWKSr2tRiZ9G+/uUkYBHl4joaE3e128LdMni8Cxi516yq0pfjn1O Qm3ePD9fN7TvzyO5ciIcj0xEG3g3V8hiBl9BBbUYsSPx8T0b9nI5us3G3YorFg/4/czm MGJXgRk6kiFp8R4/vYc+yP/7u7rjzbnN8U3EEWmRtOFtgreAV3cTB7DOV+9WhQqs4+5D O9oijYXSYL2iawNgFU7kh8C++uoj6edZ4FNxEN55xlmeZrX2iRU8UCoBiSaM9pJH1xmo ZlUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l190-v6si10705408pgd.626.2018.08.05.11.14.50; Sun, 05 Aug 2018 11:15:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726569AbeHEUR5 (ORCPT + 99 others); Sun, 5 Aug 2018 16:17:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45696 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbeHEUR5 (ORCPT ); Sun, 5 Aug 2018 16:17:57 -0400 Received: from localhost (unknown [89.188.5.116]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 28A23480; Sun, 5 Aug 2018 18:12:32 +0000 (UTC) Date: Sun, 5 Aug 2018 20:12:29 +0200 From: Greg KH To: Frank Werner-Krippendorf Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH] Staging: rtl8712: rtl871x: removed unused code, to fix a coding style issue Message-ID: <20180805181229.GA32497@kroah.com> References: <1533489152-19472-1-git-send-email-mail@kripp.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533489152-19472-1-git-send-email-mail@kripp.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 05, 2018 at 07:12:32PM +0200, Frank Werner-Krippendorf wrote: > Fixed a coding style issue. > > Signed-off-by: Frank Werner-Krippendorf > --- > drivers/staging/rtl8712/rtl871x_event.h | 10 +++++----- > drivers/staging/rtl8712/rtl871x_io.h | 2 +- > drivers/staging/rtl8712/rtl871x_pwrctrl.h | 10 +++++----- > drivers/staging/rtl8712/rtl871x_xmit.h | 14 +++++++------- > 4 files changed, 18 insertions(+), 18 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot