Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <5B63FE39.4070402@hisilicon.com>
References: <20180719160426.GA21958@jordon-HP-15-Notebook-PC>
 <CAFqt6zY_KUx0RgRiuTt6x6xmtfwD=iR8xR6665eZYmKmXKgDNA@mail.gmail.com>
 <CAFqt6zZdOJe1VmCC3=cEANEU_X05whezkFZsG+FtoS64FXnpeg@mail.gmail.com> <5B63FE39.4070402@hisilicon.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Mon, 6 Aug 2018 11:36:32 +0530
Message-ID: <CAFqt6zbuTRTxf+dw_C-YMK_qn8cB=5xWq+b_M22dep_NEWWghw@mail.gmail.com>
Subject: Re: [PATCH] gpu/drm/hisilicon: Convert drm_atomic_helper_suspend/resume()
To:     xinliang <z.liuxinliang@hisilicon.com>
Cc:     Zou Rongrong <zourongrong@gmail.com>,
        kong.kongxinwei@hisilicon.com, puck.chen@hisilicon.com,
        airlied@linux.ie, noralf@tronnes.org,
        Sean Paul <seanpaul@chromium.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Ajit Linux <ajitn.linux@gmail.com>,
        Sabyasachi Gupta <sabyasachi.linux@gmail.com>,
        Brajeswar Ghosh <brajeswar.linux@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 3, 2018 at 12:33 PM, xinliang <z.liuxinliang@hisilicon.com> wrote:
>
>
> On 2018/8/2 17:57, Souptick Joarder wrote:
>>
>> On Thu, Jul 26, 2018 at 1:37 PM, Souptick Joarder<jrdr.linux@gmail.com>
>> wrote:
>>>
>>> >On Thu, Jul 19, 2018 at 9:34 PM, Souptick Joarder<jrdr.linux@gmail.com>
>>> > wrote:
>>>>
>>>> >>convert drm_atomic_helper_suspend/resume() to use
>>>> >>drm_mode_config_helper_suspend/resume().
>>>> >>
>>>> >>Fixed one sparse warning by making hibmc_drm_interrupt
>>>> >>static.
>>>> >>
>>>> >>Signed-off-by: Souptick Joarder<jrdr.linux@gmail.com>
>>>> >>Signed-off-by: Ajit Negi<ajitn.linux@gmail.com>
>>>> >>---
>>>
>>> >
>>> >Any comment on this patch ?
>>
>> Any review comment for this patch ?
>
> Sorry for late reply. Looks good to me. Thanks.
> Reviewed-by: Xinliang Liu <z.liuxinliang@hisilicon.com>

Xinliang,

I will do little more clean up by removing ret variable from
suspend / resume function and post v2.

>
>