Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3364126imm; Mon, 6 Aug 2018 03:31:42 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf+s+VfXY4VLNUfUirC4E+J/kU7pHwj8aNly52xR2tp50LIw6paDF7tqM/bwWZbtQqoL1LV X-Received: by 2002:a63:4386:: with SMTP id q128-v6mr13991014pga.353.1533551502656; Mon, 06 Aug 2018 03:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533551502; cv=none; d=google.com; s=arc-20160816; b=o4igtggRR058s7R+dtIO7GKQzge1ZbTeEjuO5USA9mhcqSPGnap5quDvuMEibahfwp nkC/DvdYEKMBV0QB+XA81FThXqyBfe2pHhzajyCUfk0tfIiiKTqmPD8jClJjTCHYq4vO Rn4nZGFK7tuSxdJg3V4bXAf0Wmk865uYoFkDeuH524LaC3e80hp4jwN0aijwdFpWYYfw ElOcdUnx6MA3ZIziC0o0tl/JBJJYvj6VRlffaXYi0Ijyl2yh/dhdljKms9FS8Mu3A3vJ O8gdBl1HO/ntjV0u5+5kfVQUJfSKuvF9R4NTA/7hNIMnsWV2FRS53270aJVLKjRMbqQR 7bLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=bIP7d58zKE7Jz8nDhak2Ct9RIsQLnp71QrNHqVbSJu0=; b=bLCcviZAdxfJkZZ1FnUveFW/IUF7tjicwhaOYVN30vtPzRVNvFd+ezN5SLAqmYvwD/ 3+DzKDEhg4vHzkzOLHvbjGCDu8PA7YJ/e5n7oIdJdyaYKg+438umJEX9o+Xt1N5V/4mE BaW4TzWoJXEAoT/VJ5qFbok5EBKsT1aSLQ3bqT27sYK/+qvnZH2IcrbVp4EQxBj55VOs jBI0BcezPCgrWczULKDGuMw/FTbK5fxGcSO6ktFjYuBpFnSdn4p23Ax6JiC9926KuOIi 5usCWA6SoTZwRuiWwdxg/NCix4zCoSCVh3rsWBQWAguk7eotChSoSB484VcKBeI1KC4u Ym8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc5-v6si6103410plb.278.2018.08.06.03.31.27; Mon, 06 Aug 2018 03:31:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729760AbeHFMiy (ORCPT + 99 others); Mon, 6 Aug 2018 08:38:54 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:52441 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727517AbeHFMiy (ORCPT ); Mon, 6 Aug 2018 08:38:54 -0400 Received: from 79.184.254.16.ipv4.supernova.orange.pl (79.184.254.16) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83) id 54a2155ba66b4be0; Mon, 6 Aug 2018 12:30:27 +0200 From: "Rafael J. Wysocki" To: Kees Cook Cc: "Rafael J. Wysocki" , Herbert Xu , Arnd Bergmann , Eric Biggers , "Gustavo A. R. Silva" , Alasdair Kergon , Rabin Vincent , Tim Chen , Pavel Machek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Philipp Reisner , Lars Ellenberg , Jens Axboe , Giovanni Cabiddu , Mike Snitzer , Paul Mackerras , Greg Kroah-Hartman , David Howells , Johannes Berg , Tudor-Dan Ambarus , Jia-Ju Bai , Andrew Morton , Geert Uytterhoeven , Josh Poimboeuf , David Woodhouse , Will Deacon , device-mapper development , Linux PM , linux-crypto , drbd-dev@lists.linbit.com, linux-block , qat-linux@intel.com, linux-ppp@vger.kernel.org, netdev , "open list:ANDROID DRIVERS" , linux-afs@lists.infradead.org, "open list:NETWORKING DRIVERS (WIRELESS)" , Linux Kernel Mailing List Subject: Re: [PATCH v6 10/18] x86/power/64: Remove VLA usage Date: Mon, 06 Aug 2018 12:28:28 +0200 Message-ID: <1782361.6NaZWiq7ky@aspire.rjw.lan> In-Reply-To: References: <20180724164936.37477-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 25, 2018 8:01:47 PM CEST Kees Cook wrote: > On Wed, Jul 25, 2018 at 4:32 AM, Rafael J. Wysocki wrote: > > On Tue, Jul 24, 2018 at 6:49 PM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> removes the discouraged use of AHASH_REQUEST_ON_STACK by switching to > >> shash directly and allocating the descriptor in heap memory (which should > >> be fine: the tfm has already been allocated there too). > >> > >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > >> > >> Signed-off-by: Kees Cook > >> Acked-by: Pavel Machek > > > > I think I can queue this up if there are no objections from others. > > > > Do you want me to do that? > > Sure thing. It looks like the other stand-alone patches like this one > are getting taken into the non-crypto trees, so that's fine. > Applied now, thanks!