Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Reply-To: sedat.dilek@gmail.com
In-Reply-To: <c69c7292139b4e22a7d9ea3e968828d8@AcuMS.aculab.com>
References: <CAKwvOdmBtzkca-C1YpB_OYVyqFFi3P_Q8DJPaKr96DFZF0e6Hg@mail.gmail.com>
 <20180803170550.164688-1-ndesaulniers@google.com> <c69c7292139b4e22a7d9ea3e968828d8@AcuMS.aculab.com>
From:   Sedat Dilek <sedat.dilek@gmail.com>
Date:   Mon, 6 Aug 2018 12:38:26 +0200
Message-ID: <CA+icZUXtw6FUu8TpTY0Bn3BaDkb1zKuzLtBMz7oHLjJ=+2ojxw@mail.gmail.com>
Subject: Re: [PATCH] x86/irqflags: provide a declaration for native_save_fl
To:     David Laight <David.Laight@aculab.com>
Cc:     Nick Desaulniers <ndesaulniers@google.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "hpa@zytor.com" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        "jgross@suse.com" <jgross@suse.com>,
        "kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jdelvare@suse.de" <jdelvare@suse.de>,
        "astrachan@google.com" <astrachan@google.com>,
        "mka@chromium.org" <mka@chromium.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "tstellar@redhat.com" <tstellar@redhat.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 6, 2018 at 12:25 PM, David Laight <David.Laight@aculab.com> wrote:
> From: Nick Desaulniers
>> Sent: 03 August 2018 18:06
>> Fixes commit d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern
>> inline").
>>
>> It was reported that the above commit was causing users of gcc < 4.9 to
>> observe -Werror=missing-prototypes errors.
>>
>> Indeed, it seems that:
>> extern inline unsigned long native_save_fl(void) { return 0; }
>>
>> compiled with -Werror=missing-prototypes produces this warning in gcc <
>> 4.9, but not gcc >= 4.9.
>>
>> Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
>> Reported-by: David Laight <david.laight@aculab.com>
>> Reported-by: Jean Delvare <jdelvare@suse.de>
>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>
> You can add my:
>
> Tested-by: David Laight <david.laight@acuab.com>
>

Tested-by: Sedat Dilek <sedat.dilek@gmail.com>

On top of Linux v4.18-rc8 with clang version 7.0.0-svn338205.

- sed@ -