Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3521662imm; Mon, 6 Aug 2018 06:19:47 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdErTldv4K7gUR7BN3/hKgRyBvSs6Gj6X9OUNwl6ipuQm2dc36BjV4brbL6OCYwYh5e8cQO X-Received: by 2002:a63:4106:: with SMTP id o6-v6mr14775124pga.453.1533561587048; Mon, 06 Aug 2018 06:19:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533561587; cv=none; d=google.com; s=arc-20160816; b=i5lhVyRxSYPx6oL5Zmv4alJElX3F8XFxofa5xwKTDVEdAr+AWhiKUfgHCQz4RfvAME JqsauYN/HqrupfaeYqkg5CdTArIu3pnBYVIDlct3V6GjQW0R3B/hiHkvqjZeGx4rWfDM CxOYxwjxKfr0VWqy+oZyV8DTIQTTrF4B1l58ZRaLsGsgZ3s/4qWf5o5X79RAHAdBs9Wr 9NrmYWDqd3cZ8ZxNrp+uprdaN3f+9zTQFh8dq0byYlRHLjT7D9xr9ciFTgLJ/MR4JHgK aaCK/CU2/3L+KAIBYKgEC2CFlB/upGzuq7Y1tiJIVIMV3y6EInx2f48LYIDVt4d1BtbN ncxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=n2Wk8ZGLcSoBq1+86H8cJhDiQdO13qDKO2uKaV/GYSI=; b=NOiKLWeZSdsHSPklwKOydGb2DcZeini7IoSr9Oeua2+1kqngroolaOmTGGesuP06ma uOD+g7bZXozm3ze0HB2NFwU5agpamFLKdbhUet12dUe1NF7nrwo3ixco/dA+5q0S2Yd1 mrqCUrD1IE7hRSspvePMhkXD7FcFDo2WI4WxKsf/CKXUE6xW2LcrrwXpEubUD47G/+zY 3Cr6pL6rsT69ccFv5BhVZhts/h9v2NKnIS8jcz1ly/MsbaTpbVg/zhOQWnkUSIETzBlI 1VmVKow+DPhYYhWEidaxZiOdXFxeYdOOMeb3B1sn3mgHY2hupcK/Cv2qIPSLIzIz5yR2 8zuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ev+Jw2LZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13-v6si13834084pfi.147.2018.08.06.06.19.32; Mon, 06 Aug 2018 06:19:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ev+Jw2LZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730911AbeHFOqI (ORCPT + 99 others); Mon, 6 Aug 2018 10:46:08 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:42042 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727585AbeHFOqH (ORCPT ); Mon, 6 Aug 2018 10:46:07 -0400 Received: by mail-io0-f195.google.com with SMTP id n18-v6so1336339ioa.9 for ; Mon, 06 Aug 2018 05:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n2Wk8ZGLcSoBq1+86H8cJhDiQdO13qDKO2uKaV/GYSI=; b=ev+Jw2LZChz4Hk3XQM5qslxRJqYRzhV4PwXTeQqJYvwDAXTOsKyaQVrK0cV2CA3v6z p6KnmoRwDIGZg9341+SFBAReKizfrbKOtvS4nBpEqKB/pJbYjA9UE1HG5w5cQAQpr1bx N4zaLuHTQMC0htB60rOLFi0Jz+OBkN4osU3d0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n2Wk8ZGLcSoBq1+86H8cJhDiQdO13qDKO2uKaV/GYSI=; b=DKqBaf4MoST2Fm6gzKmVTLvgrx2zEWYikndU0wy5xUNYrPwdgPDNCCxPmNmBQF2lzR 4I6D4YwTYOnqN/+uEXbP2oCMqs2VM0nIghMockfcjUMRMVAEA/r5YCkE2hMmil8MpIWc dEjJc16cgYvvMP8ESY5udZ/iFccb72yvRPhNovK26JBk0SUZtkeedog+7MEuPokkmI9r WpEf9Z2mcT1gtmGkG+GIwWqxLWRPl+SS2dtnB9RDqqvc1wCr1dFCYyntBDd5migrm8tB B9iVM/LjY4WTJx9ttvl16uAKNgfgaHOW1xa6VUFcIk0VlNKp/UUm4osHs4Vc6B2tBWCg Dguw== X-Gm-Message-State: AOUpUlEmXxGJzHZoPpGOxSzeEw2mmEb5Ldk8qI3/ZlrQwM/HTJqV18KG Ww0FX+BxZUKKE91WGElxgmXNFmbFO+CQgxHUeYcsaA== X-Received: by 2002:a5e:8341:: with SMTP id y1-v6mr14001798iom.183.1533559031571; Mon, 06 Aug 2018 05:37:11 -0700 (PDT) MIME-Version: 1.0 References: <20180802153035.vjtmqwdwujvt7ojs@queper01-lin> <20180802160009.uhwwj3tqrqmv7q5a@queper01-lin> <20180802161027.v2ctgscuc4uxbb7u@queper01-lin> <20180802165924.7ywgoxj2jwftxycz@queper01-lin> <20180803081850.hj7bp5ognuywapmd@queper01-lin> <20180803155547.sxlhxpmhwcoappit@queper01-lin> <68689fcb-3cb8-4685-58ef-0bec84be2047@arm.com> <1cac0d16-9f50-ed30-2460-340b077faa57@arm.com> In-Reply-To: <1cac0d16-9f50-ed30-2460-340b077faa57@arm.com> From: Vincent Guittot Date: Mon, 6 Aug 2018 14:37:00 +0200 Message-ID: Subject: Re: [PATCH v5 09/14] sched: Add over-utilization/tipping point indicator To: Dietmar Eggemann Cc: Quentin Perret , Peter Zijlstra , "Rafael J. Wysocki" , linux-kernel , "open list:THERMAL" , "gregkh@linuxfoundation.org" , Ingo Molnar , Morten Rasmussen , Chris Redpath , Patrick Bellasi , Valentin Schneider , Thara Gopinath , viresh kumar , Todd Kjos , Joel Fernandes , "Cc: Steve Muckle" , adharmap@quicinc.com, "Kannan, Saravana" , pkondeti@codeaurora.org, Juri Lelli , Eduardo Valentin , Srinivas Pandruvada , currojerez@riseup.net, Javi Merino Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Aug 2018 at 14:29, Dietmar Eggemann wrote: > > On 08/06/2018 12:33 PM, Vincent Guittot wrote: > > On Mon, 6 Aug 2018 at 12:08, Dietmar Eggemann wrote: > >> > >> On 08/06/2018 10:40 AM, Vincent Guittot wrote: > >>> On Fri, 3 Aug 2018 at 17:55, Quentin Perret wrote: > >>>> > >>>> On Friday 03 Aug 2018 at 15:49:24 (+0200), Vincent Guittot wrote: > >>>>> On Fri, 3 Aug 2018 at 10:18, Quentin Perret wrote: > >>>>>> > >>>>>> On Friday 03 Aug 2018 at 09:48:47 (+0200), Vincent Guittot wrote: > >>>>>>> On Thu, 2 Aug 2018 at 18:59, Quentin Perret wrote: > >> > >> [...] > >> > >>>> I think we're discussing two different things right now: > >>>> 1. Should forkees go in find_energy_efficient_cpu() ? > >>>> 2. Should forkees have 0 of initial util_avg when EAS is enabled ? > >>> > >>> It's the same topic: How EAS should consider a newly created task ? > >>> > >>> For now, we let the "performance" mode selects a CPU. This CPU will > >>> most probably be worst CPU from a EAS pov because it's the idlest CPU > >>> in the idlest group which is the opposite of what EAS tries to do > >>> > >>> The current behavior is : > >>> For every new task, the cpu selection is done assuming it's a heavy > >>> task with the max possible load_avg, and it looks for the idlest cpu. > >>> This means that if the system is lightly loaded, scheduler will select > >>> most probably a idle big core. > >> > >> AFAICS, task load doesn't seem to be used for find_idlest_cpu() ( > >> find_idlest_group() and find_idlest_group_cpu()). So the forkee > >> (SD_BALANCE_FORK) is placed independently of his task load. > > > > hmm ... so what is used if load or runnable load are not used ? > > find_idlest_group() uses load and runnable load but skip spare > > capacity in case of fork > > Yes, runnable load and load are used, but from the cpus, not from the task. yes that's right, I have skipped the "task" word when reading. So scheduler looks for the idlest CPU taking into account only CPU loads. Then the task load starts to highest value until it get a chance to reduce and stabilize to its final value > > [...]