Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <a3c26117-1774-f23e-37d0-2312d4312b63@i2se.com>
References: <20180806040731.5113-1-greg@embeddedgreg.com> <a3c26117-1774-f23e-37d0-2312d4312b63@i2se.com>
From:   Greg Gallagher <greg@embeddedgreg.com>
Date:   Mon, 6 Aug 2018 08:37:49 -0400
Message-ID: <CALLqZ8QiELH0x7a4E-eQyj6ewLmBuwQ7oYmHrZQ9kUcDWhaAMQ@mail.gmail.com>
Subject: Re: [PATCH] staging/vc04_services: Fix alignment of function arguments
To:     Stefan Wahren <stefan.wahren@i2se.com>
Cc:     Eric Anholt <eric@anholt.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Mon, Aug 6, 2018 at 4:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi,
>
> Am 06.08.2018 um 06:07 schrieb Greg Gallagher:
>>
>> Fix warning generated by checkpatch.pl for alignment should match open
>> parenthesis.  This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>>   drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> index ec468d5719b1..33ae8ae8663b 100644
>> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
>> @@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
>>   };
>>     static int snd_bcm2835_spdif_default_info(struct snd_kcontrol
>> *kcontrol,
>> -       struct snd_ctl_elem_info *uinfo)
>> +                                         struct snd_ctl_elem_info *uinfo)
>>   {
>>         uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
>>         uinfo->count = 1;
>
>
> in case this is the only alignment issue in the whole driver, you can have
> my acked-by.
> Otherwise please fix the other ones in the second version.
>
> Btw there are more drivers under vc04_services so a "staging: bcm2835-audio:
> Fix alignment of functions arguments" would be better.
>
> Stefan


I'll fix the other alignment issues as well in the second version and
fix up the subject line to staging: bcm2835-audio.

thanks

Greg