Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3531026imm; Mon, 6 Aug 2018 06:28:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfX3XrYFFi0OWWE3bSqxx7F8Hj8gQcSozlNP9Q8nBTw6VV6ZF7mz5eKOLZdMPfLjzD5e+cO X-Received: by 2002:a62:f909:: with SMTP id o9-v6mr17286933pfh.141.1533562108086; Mon, 06 Aug 2018 06:28:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533562108; cv=none; d=google.com; s=arc-20160816; b=OF+RPVOJ/M5Vb5+pPWRcmKSyLq2bsMlqoIVlhn+Ztr0rydIxNUGGEbH6FfkFpaCtOQ 7vIwA2go64Md/II11egG6XZlC3sdwx+cPMVV3A29PfsriHK7kXh71xitxa/NnUXLHHvX zIwq7D8alAc14em56fDaphITVdepMWQjNXDBRcs470xmzcZ0Iq+W8UJr3cCRwiE8zPdn AganTWrj1aoAqxDQtfKB4DZ5koxklyMeMnV8FnLWM6sVFSm3gPnussxo4XTS8GxntC7S R4qXXNTTPovpE0yo4oYsMqzVaJg+gWEaWqJhDdVeQra6ImDfCvSlVqtU8MIz+FpI2P94 dpyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=HjNbmopynzTvIoI4Y9qDF+Z5xE2PIiFbLgSX4pbuuEc=; b=l/5UqLi09zJD0nkQAUZRJcCMsmoHZAOA4+NmSR35G9s2KHAHZJik0/SIPud6M6oydA bCu39boGINoCljfwTYEwrOanlsQDKLjeS4gtPg3DtmU8wP62y2S/l0KV49YqNNEEbzv0 Wc1VjuE9HeSQSY3Asuhr3qBFq+G6jKok/MG94c7cFk4eUcCrBoM3Y2UBSyWGMrdKJjnN aPaGeEzzzPLhSUPzY/Iu722zsNsHrzBqFymdgf9UexhMnA0IoFooYXAsTEH8i9TEp75T 2fsGZObZaVwuvBbCJu0vZg+ZXEcq9gdhzrXctDUt8ipeUjLWbmG9D9oiXWe0rIKOIbZp cJuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t79-v6si14561436pfa.170.2018.08.06.06.28.13; Mon, 06 Aug 2018 06:28:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729665AbeHFPgd (ORCPT + 99 others); Mon, 6 Aug 2018 11:36:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:32874 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727510AbeHFPgd (ORCPT ); Mon, 6 Aug 2018 11:36:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AD0F8AFDC; Mon, 6 Aug 2018 13:27:25 +0000 (UTC) Date: Mon, 6 Aug 2018 15:27:25 +0200 From: Johannes Thumshirn To: ard Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH 0/3] scsi: fcoe: memleak fixes Message-ID: <20180806132725.ihbi5rxvkuuppajr@linux-x5ow.site> References: <20180731134603.20089-1-jthumshirn@suse.de> <20180806092503.6ed56kukj2i236qt@linux-x5ow.site> <20180806132234.GA23827@kwaak.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180806132234.GA23827@kwaak.net> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06, 2018 at 03:22:34PM +0200, ard wrote: > Ahh, yeah, sorry. > I did test them. > I can't say I see a regression. > I also can't say I see progress, although it feels like there is > a tad less leaking. > For that I need to do some statistics. > > But for now I ack that it does not regress further. From what I've seen in your kmemleak reports, it wasn't only libfc/fcoe that was leaking memory. So kmemleak reports are welcome (especially if they confirm libfc/fcoe is clean now ;-)). @Martin can you stage these patches for 4.19? -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850