Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3559345imm; Mon, 6 Aug 2018 06:57:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdwOPzu5SDvOb8TavclGNPeUGOJdgj1R11l/4dunWV0PcY2xjHiCgJI3ZaxcSUv8dyYir7Y X-Received: by 2002:a62:9683:: with SMTP id s3-v6mr17185913pfk.191.1533563842518; Mon, 06 Aug 2018 06:57:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533563842; cv=none; d=google.com; s=arc-20160816; b=sz95mErfDAruSdngwd2aX7bqSl0i7fJfkFd1KzY8v6ZcjNC0UIh/K0jvDpdpOH32Jw gf/sk8j96VYO7ALGDwLQJDaF3CWwfY/M3hukZZCZQwIep9cw2ZnSBnESfROlkLFwFIFf zOXMxwYHQsO/YqfoQNgySG0GwX+Yo/z7hDhqrur/7F555f1BI1qPr701Z0CUkkYv+Mth uUaFAQw9H6DpGfeeQCktwiDISRxVcykEUj7U8whP17XdIAkqap5952995cX6w2RuWF/x 0hXqJISQeTLNKmr216eOksj66oB10W2o/BVKV3sT3cSocDw1SjUpIat4pqyO/9o0jnlC DGbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=YojTH9VWML1+h4rOQd5yZjc+CYSQYE+U4Sl7RD8k9ZE=; b=fR2RG3jeY3coHJIEPPoy6CdvSC0stFqpojr6g5ZOhM3fpWgukVNu05MSe+3BuOAQZc k1h0of0k6rJQ6ngS6NbuCi5y6Q+ncu7Fqr23fN7tlqWYaVCnYToACBsNcveSGVLAOwuE tMCHkqaO4rYegFYoH3g6GSVd4sSfunWYDgFUNvK4ythmvpuQwtSxhADe8nox440Etv5G uljAaAgpnDTSqFImaUfOMlNcrSYLqcXZiYl5hxYiRjsEP8GeZzNn6N4VvN0iAoxsNtE8 8y1nAFd2mGsStAjxixLeaK5RIun55EJ2YfDWjN+5x96pYTQdsJ1fOQGVWpix2q+jnK+q 92EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b16-v6si9776020pgw.478.2018.08.06.06.57.07; Mon, 06 Aug 2018 06:57:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731068AbeHFQE5 (ORCPT + 99 others); Mon, 6 Aug 2018 12:04:57 -0400 Received: from mga07.intel.com ([134.134.136.100]:31078 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727582AbeHFQE4 (ORCPT ); Mon, 6 Aug 2018 12:04:56 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2018 06:55:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,452,1526367600"; d="scan'208";a="246520891" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.164]) ([10.237.72.164]) by orsmga005.jf.intel.com with ESMTP; 06 Aug 2018 06:55:41 -0700 Subject: Re: [PATCH v3] usb: host: xhci-plat: Iterate over parent nodes for finding quirks To: Anurag Kumar Vulisha , mathias.nyman@intel.com, gregkh@linuxfoundation.org Cc: v.anuragkumar@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1533560671-32640-1-git-send-email-anurag.kumar.vulisha@xilinx.com> From: Mathias Nyman Message-ID: <532f004d-8a79-e61b-e668-958c162599aa@linux.intel.com> Date: Mon, 6 Aug 2018 16:58:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1533560671-32640-1-git-send-email-anurag.kumar.vulisha@xilinx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.08.2018 16:04, Anurag Kumar Vulisha wrote: > In xhci_plat_probe() both sysdev and pdev->dev are being used > for finding quirks. There are some drivers(like dwc3 host.c) > which adds quirks(like usb3-lpm-capable) into pdev and the logic > present in xhci_plat_probe() checks for quirks in either sysdev > or pdev for finding the quirks. Because of this logic, some of > the quirks are getting missed(usb3-lpm-capable quirk added by dwc3 > host.c driver is getting missed).This patch fixes this by iterating > over all the available parents for finding the quirks. In this way > all the quirks which are present in child or parent are correctly > updated. > > Signed-off-by: Anurag Kumar Vulisha > --- > Changes in v3: > 1. As Mathias suggested, moved the position of reading devicetree > property "imod-interval-ns" into for loop > > Changes in v2: > 1. As suggested by Mathias, restoring immod_interval changes to > default > --- Thanks, adding to queue -Mathias