Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3592099imm; Mon, 6 Aug 2018 07:25:29 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfUdmXqFk++xx8NrcUc6zcPVl9K+7GI7nkfRkAbnt7Wumf28v+n7IDRLi2prhfRnXCzjN/i X-Received: by 2002:a62:b0c:: with SMTP id t12-v6mr17353476pfi.36.1533565529104; Mon, 06 Aug 2018 07:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533565529; cv=none; d=google.com; s=arc-20160816; b=QN6FrzqCquyeeYWMc5upjPYCCUNsQ80rEdbKW3ZHidOhmYfm/fKUjFSGAUoysPoOXE zA7upuEemHM1WTPPv002/Z7BbgUHLmh7miRLzS7OR9HuKsWKyAiEh477pFbjPDyRRjwW /gExvcUfpDfwQeWqHle6ZLY3lqTMR98Tvc9Uhg7kPBSVVwCnJU80Bz5cvuDk5dwLKCfJ CfKFxWpEQ1AAj6+iOrht3J8ufRjp6LrTORYUVlEDnW1wERFMZpDFLBCp47xg7S2DA87n pqzohlgjEPd3w7tvyRWt/yK6VWZEWWTuTYyH+nl3rB7ptdQWf3/KXUUjtlF5MjrHkH9W sdBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Gst4+hgfR57cGQ0PXeJlugaOPAZRnSroL3kcFStQGeo=; b=OxgZmlXl7jTsqGCOsDoDixy5wO4ltMBGAC4On/FGPC5Sh0wvrgFeYgsYnvg04Ln/V0 K82PYb/JkvoAE32D6OnKctK2rwCZDu3LwaY+koQdPLSPplsFGNLlhSqLXrT0FIMnzJye st6uclLNz3sV+U+XW8lDFTUjVQjPCsmIbaSKLMLHBNikkh0OqBOclKorXSQfG+SKfpZ1 xhqqberRG7D9I6Pf55lHy94xTvqOm4FuDm1Dow+vIXN1aUAO93QlyPZynKEraoft32xS dIKSoK5yFUbfkynT9Qem5crkndDfz+ptABSGCDKhPmyqN6sRzHmh23o4Uwp3rFJiGUfq N5pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21-v6si12931452pgl.8.2018.08.06.07.25.14; Mon, 06 Aug 2018 07:25:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731128AbeHFQdq (ORCPT + 99 others); Mon, 6 Aug 2018 12:33:46 -0400 Received: from gw-fsck-sorbs.kwaak.net ([84.245.27.153]:44997 "EHLO mail.kwaak.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727451AbeHFQdq (ORCPT ); Mon, 6 Aug 2018 12:33:46 -0400 Received: from [192.168.0.44] (port=56627 helo=shell3.kwaak.net) by mail.kwaak.net with esmtp (Exim 4.50) id 1fmgQi-0001Pj-7S; Mon, 06 Aug 2018 16:24:17 +0200 Received: from ard by shell3.kwaak.net with local (Exim 4.80) (envelope-from ) id 1fmgQg-0001Pe-9p; Mon, 06 Aug 2018 16:24:14 +0200 Date: Mon, 6 Aug 2018 16:24:14 +0200 From: ard To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH 0/3] scsi: fcoe: memleak fixes Message-ID: <20180806142414.GB23827@kwaak.net> References: <20180731134603.20089-1-jthumshirn@suse.de> <20180806092503.6ed56kukj2i236qt@linux-x5ow.site> <20180806132234.GA23827@kwaak.net> <20180806132725.ihbi5rxvkuuppajr@linux-x5ow.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180806132725.ihbi5rxvkuuppajr@linux-x5ow.site> User-Agent: Mutt/1.5.21 (2010-09-15) X-Host-Lookup-Failed: Reverse DNS lookup failed for 192.168.0.44 (failed) X-Kwaak-Spam-Score: -2.6 X-kwaak-MailScanner: Found to be clean X-kwaak-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.304, required 5, autolearn=not spam, BAYES_00 -2.60, DNS_FROM_AHBL_RHSBL 0.29) X-MailScanner-From: ard@kwaak.net Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johannes, On Mon, Aug 06, 2018 at 03:27:25PM +0200, Johannes Thumshirn wrote: > On Mon, Aug 06, 2018 at 03:22:34PM +0200, ard wrote: > > Ahh, yeah, sorry. > > I did test them. > > I can't say I see a regression. > > I also can't say I see progress, although it feels like there is > > a tad less leaking. > > For that I need to do some statistics. > > > > But for now I ack that it does not regress further. > > From what I've seen in your kmemleak reports, it wasn't only > libfc/fcoe that was leaking memory. > > So kmemleak reports are welcome (especially if they confirm libfc/fcoe > is clean now ;-)). I've updated the ticket: https://github.com/hardkernel/linux/issues/360#issuecomment-410721997 dmesg (with full debugging): https://github.com/hardkernel/linux/files/2262858/dmesg-2018-08-06.txt and kmemleak: https://github.com/hardkernel/linux/files/2262861/kmemleak-2018-08-06.txt I'll have to take a good look at the what and why. I'm gonna git clean -x -d and rebuild the kernel, because this is weird. This is the tree I build: https://github.com/ardje/linux/tree/gb-4.14-fcoe-patch So vanilla linux-4.14 with the patch set: https://github.com/ardje/linux/commit/747bf04057a99be5b01f768654cfd61bc9f4fc6c Meh, I should try to use git for patching. I will spam some printk's later on, just to check which flows are followed (if the git clean doesn't reveal some problem, although I can't imagine). Regards, Ard -- .signature not found