Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3677456imm; Mon, 6 Aug 2018 08:44:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcl3aVCKSDvf0W6VnMlUI86LzKvDoGX5j1xmBe6bFoX2k9q/LU5CmJLFY6TpZ791v7pU9Ge X-Received: by 2002:a63:1015:: with SMTP id f21-v6mr15291553pgl.354.1533570288919; Mon, 06 Aug 2018 08:44:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533570288; cv=none; d=google.com; s=arc-20160816; b=DzK5FjQgdNyIdQnQGj/+TWyoS+LEl5Exqbs29r8K67xjX3G+Q7TqavEg/wkkfZaSFd PR5SkajdaDZYZBw3jJ946OEtbNP6oeC8R5M3EWQs1Vp0yOgfGFYkjNJdAXNmxb1mEb9Z ftrlWgcLQ73ZruxihuO+IE3n13yXqhAKRfurl+O1WswuhMV5AZS8n12mfF7x1lnziKxu YNgGPUbypooGZFfZYOHJMBGppulKG2fjfcamZOSe4d/n2ZuT9x53B7bfPvhb0V/PzQDn HQ0KEoK00vmcSKSZUDRMN26ybs2qjmOQAahVbHJbT43e501h2ILZywJWkvP3DIrrHwqc OUgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=gX+Z6YgQtu9qc8WdWjPwAGN/i9XUDl84YiK9BnmyK4w=; b=UxmVF6a/hEkbAH5J9IEGRSWcGdU+Doe2wuCiWdikE0unceExXCp9M1dWi27UvZUIXx flrBL8dnEJl3fa+tqDuO4a+aOWWU7k37kTBtJPum6SiBHAU+hQ+vID+LcA2ySrsGOa/J Wh2HbvlhYZjv1INZQOBy5UITNv/6623l6pEyp74OSwaiieusR2qxg07lyWmNOVAxR7aH eEGopWbjNPqUuxa2e14tJ+/PIuIwDjZB+NHrHMXFjgS1oZH/qD825hvp+ZRdoSmTo4iB 1TMBa6hifDaUCLF76gMlvLUkZkW/PR/gDrHFtSeikqw3bAtWatM/ydFTppS3+t5EQsv5 1cPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=EcPcdB7V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si10236497pls.385.2018.08.06.08.44.33; Mon, 06 Aug 2018 08:44:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=EcPcdB7V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732954AbeHFRwU (ORCPT + 99 others); Mon, 6 Aug 2018 13:52:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40828 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729724AbeHFRwT (ORCPT ); Mon, 6 Aug 2018 13:52:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gX+Z6YgQtu9qc8WdWjPwAGN/i9XUDl84YiK9BnmyK4w=; b=EcPcdB7Vbs28nTjI9OMi900wv Ktr5+EM3Ij/JeoZ1EsYMHMdpwJ9SlUD8UtHmM50Ih3VhYYrlgPy1Du6f37mxnHlwl8zxQl9PXfHu/ NPOZwz2dH9U/KRGIPYF0VAZH6lcjbzPjjxAFq6KGtM2E1cqjZhZnqbUqDNNcFOINQXtqCl340QBNn b59i2m4BiR4xrRtskmQGvBYDMddqc7jc3vAeMC6ivThn0fUW+Wz2yaHiX5O1Bq7goVNpXtIIih2PY 7nj948fqWvEgFbd5WpsopO5KkOhGA0KaALdtgHCx9HAZHGemaG77MzUvA7/FhG322Aown713d/exJ rP6yEjS0w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fmheX-0006LT-48; Mon, 06 Aug 2018 15:42:37 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 69964205881D3; Mon, 6 Aug 2018 17:42:35 +0200 (CEST) Date: Mon, 6 Aug 2018 17:42:35 +0200 From: Peter Zijlstra To: Fubo Chen Cc: jpoimboe@redhat.com, Ingo Molnar , bhole_prashant_q7@lab.ntt.co.jp, Linux Kernel Subject: Re: [PATCH] perf/x86/intel: Fix unwind errors from PEBS entries (mk-II) Message-ID: <20180806154235.GO2494@hirez.programming.kicks-ass.net> References: <60466ab6-311b-ad8d-2f79-32702174cb95@lab.ntt.co.jp> <20180719153347.buoe6pavpqc75zbb@treble> <20180719174311.GK2494@hirez.programming.kicks-ass.net> <20180719211954.GZ2512@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06, 2018 at 08:35:07AM -0700, Fubo Chen wrote: > On Thu, Jul 19, 2018 at 2:21 PM Peter Zijlstra wrote: > > --- a/include/uapi/linux/perf_event.h > > +++ b/include/uapi/linux/perf_event.h > > @@ -143,6 +143,8 @@ enum perf_event_sample_format { > > PERF_SAMPLE_PHYS_ADDR = 1U << 19, > > > > PERF_SAMPLE_MAX = 1U << 20, /* non-ABI */ > > + > > + __PERF_SAMPLE_CALLCHAIN_EARLY = 1UL << 63, > > }; > > The above change makes sparse unhappy :-( Sparse reports the following > complaint about __PERF_SAMPLE_CALLCHAIN_EARLY: I thought I changed that to 1ULL before commit.