Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3714994imm; Mon, 6 Aug 2018 09:20:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcHnU5JzlzzMOATbv2vODVdAsL8qBDePhaPt/kc4QNSkQVQ5pWSfW3yzqQH+VSR/ZL0KLft X-Received: by 2002:a17:902:529:: with SMTP id 38-v6mr14841494plf.145.1533572413306; Mon, 06 Aug 2018 09:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533572413; cv=none; d=google.com; s=arc-20160816; b=i4BkRO07aizErt3fMFuh8IKsZqb18aApsPzkpikT+kBAuHYrfoPOYney4aHsNZMwsc txbW8/vHk88tlw4kHzBaCtZ3RpEPVKWU/IuqQlMENm/BaQ4AHrJP9cQuuyGogQQZG6nC F9Sn3SRMVYho5fg/2z76Y5oFL7rPrIbyOYybdR1WpEqo7WUBL1mvLrcEv7yUC7xiP1f7 FWTtFAur66a4+agE5q5XN5HIIw3jDQlbj9tKqBuVJ2M5H6rygbswyYc61p+yFohjfmcw a2A19+XnDBkNqTcjoKJ0Lde5uzdjcWeXB1p6qDdHMCBicYTLZlsWThPPUqdvFEYO8vLK Vrjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=I0B/LacM7i1p1XhiFLTyQ84Se8IZIYDLwNS6oFCtwBo=; b=VfnRK+/OpzQr8AnqHH20u4PUz1S6n5slCJGvXXuxgcG4BdKtDjrg9f92AXDfG1G77k 3vAaox+tG8zV+Q/ScGKLo9DqWIdesCfNVnQbiIFKqZUb6f336s/hq5Ox1lHrLJcc4NWo qsDmeQJShwI4XIa4EQ2iOkKP4O6qXkTUVZBy9hWyIc8gYG0Ygmw0EkCtTU9ZMgzutlmz wJ4CvVXiYFeeWKcAitnai9IQXeGj8reBODSEc+PA1IrQ9OLC5ZsKF0bg2t8A+AwyLYUi TCz8f7GdpQpdD45FuzRbpyvN74CzA7uuLXU7DM4mihh5mQ1eVuWnWSF3hedUpLOpm0Kf qrgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i189-v6si11454449pgc.227.2018.08.06.09.19.57; Mon, 06 Aug 2018 09:20:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733200AbeHFS24 (ORCPT + 99 others); Mon, 6 Aug 2018 14:28:56 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:38552 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730876AbeHFS24 (ORCPT ); Mon, 6 Aug 2018 14:28:56 -0400 X-IronPort-AV: E=Sophos;i="5.51,452,1526342400"; d="scan'208";a="77238387" Date: Mon, 6 Aug 2018 18:18:59 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Juergen Gross CC: , , , , , Subject: Re: [PATCH 3/4] xen/blkfront: reorder tests in xlblk_init() Message-ID: <20180806161859.gqcc4xze5jbbuu4v@mac> References: <20180806113403.24728-1-jgross@suse.com> <20180806113403.24728-5-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180806113403.24728-5-jgross@suse.com> User-Agent: NeoMutt/20180716 X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06, 2018 at 01:34:02PM +0200, Juergen Gross wrote: > In case we don't want pv block devices we should not test parameters > for sanity and eventually print out error messages. So test precluding > conditions before checking parameters. > > Signed-off-by: Juergen Gross Reviewed-by: Roger Pau Monn? Thanks, Roger.