Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1533305419-29152-1-git-send-email-sricharan@codeaurora.org> <1533305419-29152-5-git-send-email-sricharan@codeaurora.org>
In-Reply-To: <1533305419-29152-5-git-send-email-sricharan@codeaurora.org>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 6 Aug 2018 14:35:34 -0600
Message-ID: <CAL_JsqL2g+1maJLDf0uDAWEmLtA5bUPP5Pi_pRSd3Lu-yBFq9g@mail.gmail.com>
Subject: Re: [PATCH 4/5] arm: dts: qcom: Add ipq8064-ap161.dts
To:     Sricharan <sricharan@codeaurora.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Aug 3, 2018 at 8:10 AM Sricharan R <sricharan@codeaurora.org> wrote:
>
> Add a new board dts for ipq8064-ap161.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.txt | 2 ++
>  arch/arm/boot/dts/Makefile                     | 1 +
>  arch/arm/boot/dts/qcom-ipq8064-ap161.dts       | 7 +++++++
>  3 files changed, 10 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-ipq8064-ap161.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.txt b/Documentation/devicetree/bindings/arm/qcom.txt
> index ee532e7..2325135 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.txt
> +++ b/Documentation/devicetree/bindings/arm/qcom.txt
> @@ -15,6 +15,7 @@ The 'SoC' and 'board' elements are required. All other elements are optional.
>
>  The 'SoC' element must be one of the following strings:
>
> +       ipq8064
>         apq8016
>         apq8074
>         apq8084
> @@ -30,6 +31,7 @@ The 'SoC' element must be one of the following strings:
>
>  The 'board' element must be one of the following strings:
>
> +       ap
>         cdp
>         liquid
>         dragonboard
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 37a3de7..233661a 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -772,6 +772,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>         qcom-ipq4019-ap.dk07.1-c1.dtb \
>         qcom-ipq4019-ap.dk07.1-c2.dtb \
>         qcom-ipq8064-ap148.dtb \
> +       qcom-ipq8064-ap161.dtb \
>         qcom-msm8660-surf.dtb \
>         qcom-msm8960-cdp.dtb \
>         qcom-msm8974-fairphone-fp2.dtb \
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap161.dts b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
> new file mode 100644
> index 0000000..aab5174
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "qcom-ipq8064-v1.0.dtsi"
> +
> +/ {
> +       model = "Qualcomm Technologies, Inc. IPQ8064/AP-161";
> +       compatible = "qcom,ipq8064-ap161";

Doesn't match what you documented above. I'm guessing the ap148 board
didn't either...

Rob