Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 06 Aug 2018 13:46:20 -0700 (PDT)
Message-Id: <20180806.134620.124956510948789350.davem@davemloft.net>
To:     poros@redhat.com
Cc:     netdev@vger.kernel.org, ivecera@redhat.com,
        sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
        sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use Kconfig flag to remove support of deprecated
 BE2/BE3 adapters
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180806121230.23690-1-poros@redhat.com>
References: <20180806121230.23690-1-poros@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Petr Oros <poros@redhat.com>
Date: Mon,  6 Aug 2018 14:12:28 +0200

>   Add flags to remove support of deprecated BE2/BE3 adapters.
>   BE2 disable will reduce .ko size by 2kb and BE3 by 3kb.
>   Disable both will reduce .ko size by 9kb.
> 
>   With dissabled support is also removed coresponding PCI IDs
>   and codepath with [BE2|BE3|BEx]_chip checks.
> 
>   New help style in Kconfig
> 
> Signed-off-by: Petr Oros <poros@redhat.com>

Sorry, I'm not too hot about this.

Imagine being one of the people who has one of these cards.

Pulling out detection and working'ness of devices from a driver
is a big step backwards, and I'm sorry I will don't want to be
part of something that facilitates this.

The S390 folks tried something similar in the past and I reject
those changes too.

Thanks.