Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 3/4] watchdog: hpwdt: Display module parameters.
To:     Jerry.Hoemann@hpe.com
Cc:     wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1533244541-42310-1-git-send-email-jerry.hoemann@hpe.com>
 <1533244541-42310-4-git-send-email-jerry.hoemann@hpe.com>
 <ba07e5f3-282f-0417-236d-57289d33f56c@roeck-us.net>
 <20180806231901.GA32467@anatevka.americas.hpqcorp.net>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <d1a220f1-e7ca-c4f5-9a2b-cbd622da536c@roeck-us.net>
Date:   Mon, 6 Aug 2018 19:28:46 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180806231901.GA32467@anatevka.americas.hpqcorp.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/06/2018 04:19 PM, Jerry Hoemann wrote:
> On Sat, Aug 04, 2018 at 06:13:20PM -0700, Guenter Roeck wrote:
>> On 08/02/2018 02:15 PM, Jerry Hoemann wrote:
>>> Print module parameters when the driver is loaded.
>>>
>>> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
>>> ---
>>>    drivers/watchdog/hpwdt.c | 5 +++--
>>>    1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
>>> index 8a85ddd..f098371 100644
>>> --- a/drivers/watchdog/hpwdt.c
>>> +++ b/drivers/watchdog/hpwdt.c
>>> @@ -326,8 +326,9 @@ static int hpwdt_init_one(struct pci_dev *dev,
>>>    	}
>>>    	dev_info(&dev->dev, "HPE Watchdog Timer Driver: %s"
>>> -			", timer margin: %d seconds (nowayout=%d).\n",
>>> -			HPWDT_VERSION, hpwdt_dev.timeout, nowayout);
>>> +		", timeout : %d seconds (nowayout=%d) pretimeout=%s.\n",
>>> +		HPWDT_VERSION, hpwdt_dev.timeout, nowayout,
>>> +		pretimeout ? "on" : "off");
>> When touching that, you might as well address
>>
>> WARNING: quoted string split across lines
> 
> 
> k. Think I'll split into two dev_info calls as line is too long
> to fit into 80 chars w/o splitting.
> 
> 
>>
>> Why did you add a space before ':' ? Personal preference ?
> 
> I think you're referring to "timeout : %d seconds".  Bad editting when
> going from "timer margin:" to "timeout :".  I'll fix.
> 

Yes, that is what I referred to.

> If you referring to the spaces around the ternary operator, that is
> in coding-style although checkpatch accepts w/o spaces around the
> operators.
> 
Nope, those spaces are desirable.

Guenter