Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4256611imm; Mon, 6 Aug 2018 21:05:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdOo9FP2N59wRmBEcw2/GsZjBl6GbaQqZf3D/XiZYO4/aA+GW6mSi1B8Ts9MtXXWingAyjm X-Received: by 2002:a63:375b:: with SMTP id g27-v6mr17073989pgn.59.1533614716335; Mon, 06 Aug 2018 21:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533614716; cv=none; d=google.com; s=arc-20160816; b=1EDlvSp4LGHJhxtsppofRq8FJGTMhqCh/d9rzjtNdECySXoH2BFRMSPb8bXKuBoKvU purISQmKQSt6JQJaKZbc3WOW1rC8zT9PC4qEaEc7Idd5Tt4lUfxbsbEqumXQ4e/sd4ka JeBKLgxjkfNBzR4tQx0hPXwBTTbiDI66gF+3gaOIm9lFm/jtrK7QjUUaVojXCiJiEvlu gduxIxMPsktRQbGxF3cWoc8sbofJ6+Pv08Wmrg3UgPm+JdTUELTbXyTpGHVYxQ9MGoEH Zni5WTUCoECVB2s60aGz9JChIqofy62cwtzSOZm1VFCKaLLsxu6A2p6zoCg61BuP4wEW j1nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ml1NFbHwKRBT3uB4lZWVIDLskoVMFj1nYFJENElZNGc=; b=K3cRyucrSTCDYEcZerMlSRB+ajMrBW4XHl4WfpdCiEk9+JQEWPF2YJ8oZptsfaOESF UygVCMtdnIHOSq502PvjWUuLtXmQQ3FWIEjmx6UyHji8AgLCIUyyOoPRJ8jjrACIWSuf /k+1/iBPcg+BUHqmzZtDr/HOfIj4kKSFrmb6NyACUhspEPnx6pwLxRvvUHf9q4l2ylYn vuuy9iao8j6pk0lwQDd00nAQdrShgvBpzx1umcK8r0DKrnQEv0ASJ6muIbCzSQzfskkq IYziTWT1jI+KbgWTs6Bfx2P3aV42dkXfEtxhJqLo1vZ+z2Hv6H24zKrngGYsWA9or7D1 q0OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l64-v6si249675pga.348.2018.08.06.21.05.01; Mon, 06 Aug 2018 21:05:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731209AbeHGFJ1 (ORCPT + 99 others); Tue, 7 Aug 2018 01:09:27 -0400 Received: from mga02.intel.com ([134.134.136.20]:25252 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727216AbeHGFJ0 (ORCPT ); Tue, 7 Aug 2018 01:09:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2018 19:57:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,453,1526367600"; d="scan'208";a="61159734" Received: from chejianj-opti.sh.intel.com ([10.239.154.125]) by fmsmga008.fm.intel.com with ESMTP; 06 Aug 2018 19:57:16 -0700 From: Jian Jun Chen To: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: kraxel@redhat.com, mst@redhat.com, jasowang@redhat.com, yu1.wang@intel.com, shuo.a.liu@intel.com, jie.deng@intel.com, conghui.chen@intel.com, Jian Jun Chen Subject: [PATCH] virtio-input: reset device when going to sleep Date: Tue, 7 Aug 2018 11:02:10 +0800 Message-Id: <20180807030210.16543-1-jian.jun.chen@intel.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When going to sleep all virtqueues are deleted, memory used for descriptor table entries are freed. Device reset is required in this case to notify the backend driver. Signed-off-by: Jian Jun Chen --- drivers/virtio/virtio_input.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 3a0468f2ceb0..20ea660bf1fc 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -332,12 +332,16 @@ static void virtinput_remove(struct virtio_device *vdev) static int virtinput_freeze(struct virtio_device *vdev) { struct virtio_input *vi = vdev->priv; + void *buf; unsigned long flags; spin_lock_irqsave(&vi->lock, flags); vi->ready = false; spin_unlock_irqrestore(&vi->lock, flags); + vdev->config->reset(vdev); + while ((buf = virtqueue_detach_unused_buf(vi->sts)) != NULL) + kfree(buf); vdev->config->del_vqs(vdev); return 0; } -- 2.17.1