Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Aug 2018 10:46:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Leonardo =?iso-8859-1?Q?Br=E1s?= <leobras.c@gmail.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] staging: fbtft: Includes parenthesis around macro
 parameters and avoids multiple usage of macro parameter - Style
Message-ID: <20180807074602.b4bksw5ridqvphxl@mwanda>
References: <cover.1533614243.git.leobras.c@gmail.com>
 <3cac26238f63cac9123ad767341daead9aec7717.1533614243.git.leobras.c@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3cac26238f63cac9123ad767341daead9aec7717.1533614243.git.leobras.c@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 07, 2018 at 01:07:41AM -0300, Leonardo Br?s wrote:
> Signed-off-by: Leonardo Br?s <leobras.c@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft.h | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> index 41ac00239aa3..eb2bdc4870be 100644
> --- a/drivers/staging/fbtft/fbtft.h
> +++ b/drivers/staging/fbtft/fbtft.h
> @@ -411,17 +411,21 @@ module_exit(fbtft_driver_module_exit)
>  #define DEBUG_REQUEST_GPIOS_MATCH	BIT(30)
>  #define DEBUG_VERIFY_GPIOS		BIT(31)
>  
> -#define fbtft_init_dbg(dev, format, arg...)                  \
> -do {                                                         \
> -	if (unlikely((dev)->platform_data &&                 \
> -	    (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
> -		dev_info(dev, format, ##arg);                \
> +#define fbtft_init_dbg(dev, format, arg...)				\
> +do {									\
> +	typeof(dev) _dev = (dev);					\
> +	struct fbtft_platform_data *pddev = (void *)_dev->platform_data;\
> +	if (unlikely(pddev &&				\
> +	    (pddev->display.debug &					\
> +	     DEBUG_DRIVER_INIT_FUNCTIONS)))				\
> +		dev_info(_dev, (format), ##arg);			\
>  } while (0)

We're never going to hit this bug ever...  Let's not over engineer
things just for pretend reasons.

Also let's just delete this and replace it with dev_dbg().  You can
turn dev_dbg on for just one function so it already provides everything
we need.

regards,
dan carpenter