Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4610952imm; Tue, 7 Aug 2018 04:36:57 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcAntEHYTUCFrqLuGn/5w7ZOQA0H/H0cfL8BhXFYMnRrpL9+6EYk8p7YOzDqCSEd9IavQYM X-Received: by 2002:a17:902:6ac7:: with SMTP id i7-v6mr18016313plt.288.1533641817561; Tue, 07 Aug 2018 04:36:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533641817; cv=none; d=google.com; s=arc-20160816; b=Cwb8B9j+vnz6yi87AOWe5GgsDyY97iNKUBqkhluHMzjSGaETHmejlfdF1sMfkJ4FUJ F+Um88VgOQ3qwlWMFaYlBdu/5YKkPJw6hLvj5gp79CZJwo6jl4YisKETaZeID/WTFa45 SIRjhjHBXpZzFVuYp5gSG++0lQuCRtZgtkT+y2LXzaxNcE+SHzHVy9Dl4kqryY8l0Ra6 SRdEqUs+YvVGBbRcgidJp0JKEmV3iD9nJ1FRcqnezi2zE1znHboD0oZZ0yUiqbmi+GWE 9bX7AYMpcOjMvT5ojhsXLauJacgbVxd/9bta0sOBYdzni4vM02auvco1VOgj+TmTMi8i 86Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=cHOvwM7Zj44kHscBgECK1KffnBrXd2XTeaY5kd8ALo4=; b=pJmupP8/y4eepGRv3ZS06RahpAiZIvuJdvYg4URoG2j15M5F0XcjojQyHBKlNwjO0f o3aUrXEAM/vpLaGmkzvyAy+ru3VdT6AjHwMQ93GLWyZ8WB0V4hJ7z6Oe6d+nfTI8LKGw YdL3hHIspw4GYQXc7YJJnG5eRhYWqG7hXyKaCfIT3VOiFiH14cDuYn79oBIHJDfSxukt ESXwgzrEwMJ77pso+c6n3P6tmEMVvOLPw/NDivF3xbYIsVUdR05EQ/d+YoMy0qzorlTy qTXR/cXTKYN9vQgaFXTDzSq0CmrFy1fykzIEb2uSoLxyVraiYa450TFu5Rk6YvMDCT57 uVlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y5-v6si1278399pgy.43.2018.08.07.04.36.43; Tue, 07 Aug 2018 04:36:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388882AbeHGNtP (ORCPT + 99 others); Tue, 7 Aug 2018 09:49:15 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:39074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726555AbeHGNtO (ORCPT ); Tue, 7 Aug 2018 09:49:14 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 64FF240216E4; Tue, 7 Aug 2018 11:35:20 +0000 (UTC) Received: from [10.43.2.69] (unknown [10.43.2.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id E88E41C5B7; Tue, 7 Aug 2018 11:35:18 +0000 (UTC) Subject: Re: [PATCH] Use Kconfig flag to remove support of deprecated BE2/BE3 adapters To: Christoph Hellwig , Petr Oros Cc: netdev@vger.kernel.org, Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , "David S. Miller" , linux-kernel@vger.kernel.org References: <20180806121230.23690-1-poros@redhat.com> <20180806162153.GA22040@infradead.org> From: Ivan Vecera Message-ID: Date: Tue, 7 Aug 2018 13:35:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180806162153.GA22040@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 07 Aug 2018 11:35:20 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 07 Aug 2018 11:35:20 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ivecera@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.8.2018 18:21, Christoph Hellwig wrote: > On Mon, Aug 06, 2018 at 02:12:28PM +0200, Petr Oros wrote: >> Add flags to remove support of deprecated BE2/BE3 adapters. >> BE2 disable will reduce .ko size by 2kb and BE3 by 3kb. >> Disable both will reduce .ko size by 9kb. >> >> With dissabled support is also removed coresponding PCI IDs >> and codepath with [BE2|BE3|BEx]_chip checks. > > deprecated seems like a really odd world for hardware. > > Are they just old? Did they never ship in large numbers? > > If you just make some cards optional why not also add options > for families of newer cards for those who only have the older ones > in their systems? > This also makes sense. I.