Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFT 4/4] ARM: dts: exynos: Add LDO28 regulator on Exynos5422
 Odroid boards
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Date:   Tue, 7 Aug 2018 12:59:48 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
        Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180806160933.6578-4-krzk@kernel.org>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <20180807105950eucas1p1e48a3d064afb4d601fa33eeb67f0ba02~IlRTyxXuT0840608406eucas1p1t@eucas1p1.samsung.com>
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20180806160933.6578-1-krzk@kernel.org>
        <CGME20180806160955epcas4p14c924297f156db1dcb30ce543bc2d79a@epcas4p1.samsung.com>
        <20180806160933.6578-4-krzk@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Krzysztof,

On 2018-08-06 18:09, Krzysztof Kozlowski wrote:
> The LDO28 is used only on Odroid XU3 for Display Port.  Define it so DTS
> will describe entire hardware.
>
> Depending on bootloader behavior this might affect the Display Port
> because none of drivers are enabling it. By default it is off in S2MPS11
> PMIC reset values.  However it could be enabled by bootloader so in such
> case kernel will later disable it as unused regulator.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Odroid XU3 boots fine with this patch. Display Port is not yet enabled in
mainline for OdroidXU3, so there is not much else to test for now.

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>
> Not tested on Odroid XU3 with Display Port.
> ---
>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 7 +++++++
>   arch/arm/boot/dts/exynos5422-odroidxu3.dts    | 6 ++++++
>   2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> index b0dc9cc81b94..178e1064cfc7 100644
> --- a/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroid-core.dtsi
> @@ -331,6 +331,13 @@
>   				regulator-always-on;
>   			};
>   
> +			ldo28_reg: LDO28 {
> +				/* Used on XU3 */
> +				regulator-name = "vdd_ldo26";
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <3950000>;
> +			};
> +
>   			ldo29_reg: LDO29 {
>   				/* Unused */
>   				regulator-name = "vdd_ldo29";
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 0322f281912c..db0bc17a667b 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -49,6 +49,12 @@
>   	};
>   };
>   
> +&ldo28_reg {
> +	regulator-name = "dp_p3v3";
> +	regulator-min-microvolt = <3300000>;
> +	regulator-max-microvolt = <3300000>;
> +};
> +
>   &pwm {
>   	/*
>   	 * PWM 0 -- fan

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland