Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        Madalin-cristian Bucur <madalin.bucur@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>
Subject: RE: [PATCH net-next] [RFC] dpaa2-eth: Move DPAA2 Ethernet driver from
 staging to drivers/net
Thread-Topic: [PATCH net-next] [RFC] dpaa2-eth: Move DPAA2 Ethernet driver
 from staging to drivers/net
Thread-Index: AQHUK0TQAhBfBUb5JkG7x+SRGzuJ9KSuO3GAgAYatRA=
Date:   Tue, 7 Aug 2018 13:59:26 +0000
Message-ID: <AM3PR04MB3387FF9574B9C0509F54DA294270@AM3PR04MB338.eurprd04.prod.outlook.com>
References: <20180803161221.6322-1-ruxandra.radulescu@nxp.com>
 <20180803164239.GG15029@lunn.ch>
In-Reply-To: <20180803164239.GG15029@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f98859b-018a-45d6-719a-08d5fc6dfcf5
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2018 13:59:26.6370
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1169
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@lunn.ch]
> Sent: Friday, August 3, 2018 7:43 PM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: netdev@vger.kernel.org; davem@davemloft.net;
> gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>; Laurentiu
> Tudor <laurentiu.tudor@nxp.com>; Madalin-cristian Bucur
> <madalin.bucur@nxp.com>; Horia Geanta <horia.geanta@nxp.com>
> Subject: Re: [PATCH net-next] [RFC] dpaa2-eth: Move DPAA2 Ethernet driver
> from staging to drivers/net
>=20
> > +static int dpaa2_eth_probe(struct fsl_mc_device *dpni_dev)
> > +{
> > +	struct device *dev;
> > +	struct net_device *net_dev =3D NULL;
> > +	struct dpaa2_eth_priv *priv =3D NULL;
> > +	int err =3D 0;
> > +
> > +	dev =3D &dpni_dev->dev;
> > +
> > +	/* Net device */
> > +	net_dev =3D alloc_etherdev_mq(sizeof(*priv),
> DPAA2_ETH_MAX_TX_QUEUES);
> > +	if (!net_dev) {
> > +		dev_err(dev, "alloc_etherdev_mq() failed\n");
> > +		return -ENOMEM;
> > +	}
> > +
> > +	SET_NETDEV_DEV(net_dev, dev);
> > +	dev_set_drvdata(dev, net_dev);
> > +
> > +	priv =3D netdev_priv(net_dev);
> > +	priv->net_dev =3D net_dev;
> > +
> > +	priv->iommu_domain =3D iommu_get_domain_for_dev(dev);
> > +
> > +	/* Obtain a MC portal */
> > +	err =3D fsl_mc_portal_allocate(dpni_dev,
> FSL_MC_IO_ATOMIC_CONTEXT_PORTAL,
> > +				     &priv->mc_io);
> > +	if (err) {
> > +		if (err =3D=3D -ENXIO)
> > +			err =3D -EPROBE_DEFER;
> > +		else
> > +			dev_err(dev, "MC portal allocation failed\n");
> > +		goto err_portal_alloc;
> > +	}
> > +
> > +	/* MC objects initialization and configuration */
> > +	err =3D setup_dpni(dpni_dev);
> > +	if (err)
> > +		goto err_dpni_setup;
> > +
> > +	err =3D setup_dpio(priv);
> > +	if (err)
> > +		goto err_dpio_setup;
> > +
> > +	setup_fqs(priv);
> > +
> > +	err =3D setup_dpbp(priv);
> > +	if (err)
> > +		goto err_dpbp_setup;
> > +
> > +	err =3D bind_dpni(priv);
> > +	if (err)
> > +		goto err_bind;
> > +
> > +	/* Add a NAPI context for each channel */
> > +	add_ch_napi(priv);
> > +
> > +	/* Percpu statistics */
> > +	priv->percpu_stats =3D alloc_percpu(*priv->percpu_stats);
> > +	if (!priv->percpu_stats) {
> > +		dev_err(dev, "alloc_percpu(percpu_stats) failed\n");
> > +		err =3D -ENOMEM;
> > +		goto err_alloc_percpu_stats;
> > +	}
> > +	priv->percpu_extras =3D alloc_percpu(*priv->percpu_extras);
> > +	if (!priv->percpu_extras) {
> > +		dev_err(dev, "alloc_percpu(percpu_extras) failed\n");
> > +		err =3D -ENOMEM;
> > +		goto err_alloc_percpu_extras;
> > +	}
> > +
> > +	err =3D netdev_init(net_dev);
> > +	if (err)
> > +		goto err_netdev_init;
>=20
> At the end of netdev_init() you call netdev_register(). From that
> point on, you device is live. Its .ndo's can be called....
>=20
> > +
> > +	/* Configure checksum offload based on current interface flags */
> > +	err =3D set_rx_csum(priv, !!(net_dev->features & NETIF_F_RXCSUM));
> > +	if (err)
> > +		goto err_csum;
> > +
> > +	err =3D set_tx_csum(priv, !!(net_dev->features &
> > +				   (NETIF_F_IP_CSUM |
> NETIF_F_IPV6_CSUM)));
> > +	if (err)
> > +		goto err_csum;
> > +
> > +	err =3D alloc_rings(priv);
> > +	if (err)
> > +		goto err_alloc_rings;
>=20
> How well does the device work if it has not allocated the rings yet,
> when it is asked to do something?
>=20
> > +
> > +	net_dev->ethtool_ops =3D &dpaa2_ethtool_ops;
> > +
> > +	err =3D setup_irqs(dpni_dev);
>=20
> How well do it work without interrupts being set up?
>=20
> > +	if (err) {
> > +		netdev_warn(net_dev, "Failed to set link interrupt, fall back
> to polling\n");
> > +		priv->poll_thread =3D kthread_run(poll_link_state, priv,
> > +						"%s_poll_link", net_dev-
> >name);
> > +		if (IS_ERR(priv->poll_thread)) {
> > +			netdev_err(net_dev, "Error starting polling
> thread\n");
> > +			goto err_poll_thread;
> > +		}
> > +		priv->do_link_poll =3D true;
> > +	}
>=20
> Probably the correct place to register the netdev is here.

Good point, I'll fix it in v2.

Thanks a lot,
Ioana