Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4887108imm; Tue, 7 Aug 2018 08:58:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcyM70Cro2RXzBeLGP2pY93/wyTKxV4ZmToEfK8L1TkbazjG/znYM5kFOSsXg9Cx5XbrXtl X-Received: by 2002:a62:c410:: with SMTP id y16-v6mr22413135pff.161.1533657524923; Tue, 07 Aug 2018 08:58:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533657524; cv=none; d=google.com; s=arc-20160816; b=PLn6hMoAYTXFpzWybbihkB2SlVMxMIy1200ZRTfR3Q/ErD32nZZyfinhHE+O5aA2KC OEGBwnjPNlZsGIKftc70TVA1vlASw5yWCKxcZ9i2JIfFEeSTHsq+Yz6KAtfUilKkNGhG GFOp9O8bcJTivNJAE/5S81qdqBz3zLsTW94c7uBvavx4cUSqPtaiYlnEXvsbCZaBpwm+ 5nVRSNtXtfT1sZpX0pkzKOIGo+wzrXCBw/l5h+uKO4vJgIBIIR6bti6QwFmjEfiBlQ8w xJG6CzEw2etKM7GJoq/SylE/xahngORXEaZlmK7Qgl3aXp8GJNp56Tes5q8dM3Y5C+ab qV8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=ETRP6QTNgwTdRf6k5LCso71GbdFDWK4N3Yw3g8t40HI=; b=wvTvNZqgWE7e0VrmhF+QSBYndUwYFIzmLt/j8ZLlaaCogrx34vH9XhPIvVvt8ebUP6 nOEoX4xZWNMEdinB0ep8YiPpYwRpQdBBvch8N7XBSR3/FAWfJrrQgG59kNMk2IMvkphk Lq6qZUK0h313RXZLNS0mrNM2wszSUe35Gv88kaiVHFAQIe2qCrChWBnzfrBhI2NhZ4n+ 9oZeQ01jNzd5GUbd0OInVPzUpEwOGvKvVGkQrGnU66cDJwouRsReqLZ9SLif9jn3jyFe 2ZxQmfZnSqqf2twt6SVNIyB4CdTVE+HlX6hshQSGo3c/65d6+7d4dgjrcM1owkkZxUPu 1FYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="ZQVlx/rj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y71-v6si1707253pgd.223.2018.08.07.08.58.30; Tue, 07 Aug 2018 08:58:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b="ZQVlx/rj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389385AbeHGQOW (ORCPT + 99 others); Tue, 7 Aug 2018 12:14:22 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:41774 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389375AbeHGQOV (ORCPT ); Tue, 7 Aug 2018 12:14:21 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w77Ds5Eq090848; Tue, 7 Aug 2018 13:59:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ETRP6QTNgwTdRf6k5LCso71GbdFDWK4N3Yw3g8t40HI=; b=ZQVlx/rjK06Y5zcze6a7MPbduKxwd56khTUJHFgYrGBVuqOtW7Htc/RrI8xEIycNm11u KfJaXO7fix2OvZIhPOPIqjEtYqkza7QjCB1JdlTaxjr39HMPeq8saP2DmLfyH0jjZNCd pM7vgqVpuaFuCtAxzP5uoGwLSRyVFPuj2wnoP9vytt3i+zzJsV+WdfIM/trO7QEIuKxx zs/p4ls1eeNuO08xmodUPN6hAQZKQ7WiH1djc7kvHglRU7SeL9nLiZdpnbHpFnPiKiev OBoyFJ6QWE0nFEJ5iZDwkUih4ffNRCagrtQx6xtyxxwHM5ChaZ3eg5uXPxa/GvnRwys+ tg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2kn43nsgkr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Aug 2018 13:59:37 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w77Dxa59012987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Aug 2018 13:59:36 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w77DxZNe003587; Tue, 7 Aug 2018 13:59:35 GMT Received: from dhcp-burlington7-2nd-B-east-10-152-55-162.usdhcp.oraclecorp.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Aug 2018 06:59:35 -0700 Subject: Re: [PATCH 0/4] xen: various cleanups To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org Cc: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com References: <20180717120113.12756-1-jgross@suse.com> <395f02c9-9893-e8fc-2b51-4229c66b796b@suse.com> From: Boris Ostrovsky Openpgp: preference=signencrypt Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= xsFNBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABzTNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT7CwXgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uzsFNBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABwsFfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Tue, 7 Aug 2018 10:00:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <395f02c9-9893-e8fc-2b51-4229c66b796b@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8977 signatures=668707 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=847 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808070142 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2018 09:10 AM, Juergen Gross wrote: > On 17/07/18 14:01, Juergen Gross wrote: >> Some Xen related cleanups: >> - move some pv-only code from CONFIG_XEN to CONFIG_XEN_PV >> - use CONFIG_XEN_PVHVM in Makefile instead of #ifdef around a complete source >> - add SPDX identifier where missing >> >> Juergen Gross (4): >> xen: move pv irq related functions under CONFIG_XEN_PV umbrella >> xen: move pv specific parts of arch/x86/xen/mmu.c to mmu_pv.c >> xen: link platform-pci-unplug.o only if CONFIG_XEN_PVHVM >> xen: add SPDX identifier in arch/x86/xen files >> >> arch/x86/entry/entry_32.S | 8 +- >> arch/x86/entry/entry_64.S | 8 +- >> arch/x86/xen/Makefile | 41 ++++++-- >> arch/x86/xen/efi.c | 14 +-- >> arch/x86/xen/enlighten.c | 2 + >> arch/x86/xen/enlighten_hvm.c | 2 + >> arch/x86/xen/grant-table.c | 25 +---- >> arch/x86/xen/mmu.c | 188 +------------------------------------ >> arch/x86/xen/mmu_pv.c | 140 +++++++++++++++++++++++++++ >> arch/x86/xen/p2m.c | 2 + >> arch/x86/xen/pci-swiotlb-xen.c | 2 + >> arch/x86/xen/platform-pci-unplug.c | 18 +--- >> arch/x86/xen/vdso.h | 2 + >> arch/x86/xen/xen-pvh.S | 15 +-- >> include/xen/interface/memory.h | 6 -- >> include/xen/xen-ops.h | 133 +++++++++++++++++--------- >> 16 files changed, 287 insertions(+), 319 deletions(-) >> > Boris, any objections? This series had my R-b, but I was waiting for x86 maintainers to ack the first patch. But now that I looked at this again, I wonder whether +#ifdef CONFIG_XEN  BUILD_INTERRUPT3(xen_hvm_callback_vector, HYPERVISOR_CALLBACK_VECTOR,           xen_evtchn_do_upcall) +#endif and +#ifdef CONFIG_XEN  apicinterrupt3 HYPERVISOR_CALLBACK_VECTOR \      xen_hvm_callback_vector xen_evtchn_do_upcall +#endif should be under XEN_PVHVM -boris -boris