Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Aug 2018 08:22:08 -0700
From:   Dennis Zhou <dennisszhou@gmail.com>
To:     Tejun Heo <tj@kernel.org>
Cc:     Christopher Lameter <cl@linux.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Roman Gushchin <guro@fb.com>, kernel-team@fb.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: add percpu populated pages count to meminfo
Message-ID: <20180807152207.GC59704@dennisz-mbp.dhcp.thefacebook.com>
References: <20180807005607.53950-1-dennisszhou@gmail.com>
 <0100016514bb069d-a6532c9a-b1ca-4eba-8644-c5b3935e3bd8-000000@email.amazonses.com>
 <20180807151146.GB3978217@devbig004.ftw2.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180807151146.GB3978217@devbig004.ftw2.facebook.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tejun,

On Tue, Aug 07, 2018 at 08:11:46AM -0700, Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 07, 2018 at 02:12:06PM +0000, Christopher Lameter wrote:
> > > @@ -121,6 +122,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
> > >  		   (unsigned long)VMALLOC_TOTAL >> 10);
> > >  	show_val_kb(m, "VmallocUsed:    ", 0ul);
> > >  	show_val_kb(m, "VmallocChunk:   ", 0ul);
> > > +	show_val_kb(m, "PercpuPopulated:", pcpu_nr_populated_pages());
> > 
> > Populated? Can we avoid this for simplicities sake: "Percpu"?
> > 
> > We do not count pages that are not present elsewhere either and those
> > counters do not have "populated" in them.
> 
> Yeah, let's do "Percpu".
> 

Sounds good, I've dropped populated.

Thanks,
Dennis