Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5002169imm; Tue, 7 Aug 2018 10:54:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpciICsvs8maJl4mz0M/pjRC06b7jsxF4txBdrCwEgVj6sm7Umd+SWz3SRdOPO/Kq2Wl3j+5 X-Received: by 2002:a62:6a01:: with SMTP id f1-v6mr23057809pfc.156.1533664457368; Tue, 07 Aug 2018 10:54:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533664457; cv=none; d=google.com; s=arc-20160816; b=GKZa2K9mLfCM/sAs0hTerGUTQJwkYRmjNKrRdDvw03sKl13uv+viavs2ddolODcZSa a5HxDbwV8Bg0gsvigX8ZbOFT+jjIuJuIfHViSiqwBWebyBvdU9Ouq/Ck33BOdhIIFWoH uyKFP8KtYYvWQYvAgn1SA0sP0r6i10IDlGugY32VGoXCE6lgHnlKj/EwJwCUIcl8HWna 7pZS23+N18U8ZcUXinRNTqyhm+gOifEXgXDv7HxnDmUuvtvfbkT8FnKbkx2vF5pZaE7Q NrVzu32K9WSBl5Avf3Y1abgyQnF0gIDb4Eq8eFV5wslXtnVcyjdF6xQM/p4l4MLnA1I4 q5pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=plDgoxaB+lEX3W+zGUZN7QiyYQ/fic77TAjL0dwoKHQ=; b=b1Sy4v02cVuYuM8oNFiTLQUDKWpqKjS0Wvqx8YinEk3VA8KXZT9sZlIqdRECcpT/IK aiLJHaBamJu4WKv4hXWWMvF+oSbsBi5PKc9kdSlmoCGeY1n6kcuvp3ehS7l8WmpoQCCe L07a0e9oJAZz2m7MYr8UonkoOeutpi9LxcV5OnBumKd+1AcvTFDGSCKpfquVQNMQ6+Wz eH2+Ila3dLXKvqdypQZd/i8OLAVbrPTzyqFkapA+7t4eyZ/5mJgjob9FpmIbfHhEHxE3 T9kxO6kDUOFtL67IzuDhAbOCQbcDQevG7DqFwg0XRkjmFf07DoUFU91/dNj1UY7nmn6l hUoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a21-v6si1975952pgm.417.2018.08.07.10.54.02; Tue, 07 Aug 2018 10:54:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389284AbeHGTGR (ORCPT + 99 others); Tue, 7 Aug 2018 15:06:17 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:37003 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731069AbeHGTGQ (ORCPT ); Tue, 7 Aug 2018 15:06:16 -0400 Received: by mail-it0-f65.google.com with SMTP id h20-v6so23879877itf.2; Tue, 07 Aug 2018 09:51:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=plDgoxaB+lEX3W+zGUZN7QiyYQ/fic77TAjL0dwoKHQ=; b=rblMPgk3FZWe+0AvZICW1qqhLwTJB4ZsOZ8yJ8+bDAbUe9qfospYVi8wVJKreXJ78B cODme6Nc+gHpQHi9Mxf9IiAmB7V8fcqn5hs/HxXJOTHNBWg0tAcsesG9/9ymuL72Vuwd apLlvlqokJAauW/e+efKz7WEE1EwouibUC7cpFfiTU9b4DUnIWWDZf2hGElbzusX1WjT yYnFCplx99WoU4NWqLk7iURzCPRSOJqDalaS5uEWV7hPv2685PgFP3+Z11RvQp2Wqduy 2PsjPQZbhgoVysfhy8dH/MGOWsNDyjvD23Fu5Hq2qXUkJcBJ6mebBVxZPzcCjywWPNP3 U2dw== X-Gm-Message-State: AOUpUlHDHFvchY3xUMiHOazVoLAxiS8r5tlHxvhXSTuhLNhBGR9odKdC 4QDL/NR+g915FDheS5TNDQ== X-Received: by 2002:a24:ed84:: with SMTP id r126-v6mr2668830ith.58.1533660665031; Tue, 07 Aug 2018 09:51:05 -0700 (PDT) Received: from localhost ([24.51.61.72]) by smtp.gmail.com with ESMTPSA id y14-v6sm496241iol.60.2018.08.07.09.51.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Aug 2018 09:51:04 -0700 (PDT) Date: Tue, 7 Aug 2018 10:51:03 -0600 From: Rob Herring To: Saravana Kannan Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mark Rutland , georgi.djakov@linaro.org, vincent.guittot@linaro.org, daidavid1@codeaurora.org, bjorn.andersson@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] PM / devfreq: Add devfreq driver for interconnect bandwidth voting Message-ID: <20180807165103.GA23354@rob-hp-laptop> References: <1533171465-25508-2-git-send-email-skannan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1533171465-25508-2-git-send-email-skannan@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 01, 2018 at 05:57:42PM -0700, Saravana Kannan wrote: > This driver registers itself as a devfreq device that allows devfreq > governors to make bandwidth votes for an interconnect path. This allows > applying various policies for different interconnect paths using devfreq > governors. > > Example uses: > * Use the devfreq performance governor to set the CPU to DDR interconnect > path for maximum performance. > * Use the devfreq performance governor to set the GPU to DDR interconnect > path for maximum performance. > * Use the CPU frequency to device frequency mapping governor to scale the > DDR frequency based on the needs of the CPUs' current frequency. > > Signed-off-by: Saravana Kannan > --- > Documentation/devicetree/bindings/devfreq/icbw.txt | 21 ++++ Please make bindings separate a patch. > drivers/devfreq/Kconfig | 13 +++ > drivers/devfreq/Makefile | 1 + > drivers/devfreq/devfreq_icbw.c | 116 +++++++++++++++++++++ > 4 files changed, 151 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/icbw.txt > create mode 100644 drivers/devfreq/devfreq_icbw.c > > diff --git a/Documentation/devicetree/bindings/devfreq/icbw.txt b/Documentation/devicetree/bindings/devfreq/icbw.txt > new file mode 100644 > index 0000000..36cf045 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/icbw.txt > @@ -0,0 +1,21 @@ > +Interconnect bandwidth device > + > +icbw is a device that represents an interconnect path that connects two > +devices. This device is typically used to vote for BW requirements between > +two devices. Eg: CPU to DDR, GPU to DDR, etc I'm pretty sure this doesn't represent a h/w device. This usage doesn't encourage me to accept the interconnects binding either. > + > +Required properties: > +- compatible: Must be "devfreq-icbw" > +- interconnects: Pairs of phandles and interconnect provider specifier > + to denote the edge source and destination ports of > + the interconnect path. See also: > + Documentation/devicetree/bindings/interconnect/interconnect.txt > +- interconnect-names: Must have one entry with the name "path". That's pretty useless... > + > +Example: > + > + qcom,cpubw { Someone in QCom please broadcast to stop using qcom,foo for node names. It is amazing how consistent you all are. If only folks were as consistent in reading Documentation/devicetree/bindings/submitting-patches.txt. Rob