Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 Aug 2018 18:57:14 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Nick Desaulniers <ndesaulniers@google.com>
cc:     hpa@zytor.com, david.laight@aculab.com,
        LKML <linux-kernel@vger.kernel.org>, jdelvare@suse.de,
        Ingo Molnar <mingo@kernel.org>,
        linux-tip-commits@vger.kernel.org, sedat.dilek@gmail.com
Subject: Re: [tip:x86/urgent] x86/irqflags: Provide a declaration for
 native_save_fl
In-Reply-To: <CAKwvOdnXqw_ZXD2tnPYdVdRtdKqi4hK5mLZ7ELyXMhrbNzyWfw@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.1808071854590.5883@nanos.tec.linutronix.de>
References: <20180803170550.164688-1-ndesaulniers@google.com> <tip-208cbb32558907f68b3b2a081ca2337ac3744794@git.kernel.org> <CAKwvOdmxaE7p-fgaaeCE17bbTf0iYmHQgWT2D6FM7U5fwUoN1Q@mail.gmail.com> <alpine.DEB.2.21.1808070924170.1788@nanos.tec.linutronix.de>
 <CAKwvOdnXqw_ZXD2tnPYdVdRtdKqi4hK5mLZ7ELyXMhrbNzyWfw@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 7 Aug 2018, Nick Desaulniers wrote:
> On Tue, Aug 7, 2018 at 12:29 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Mon, 6 Aug 2018, Nick Desaulniers wrote:
> > > also, there were tested by's reported:
> > >
> > > Tested-by: David Laight <david.laight@acuab.com>
> > > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> >
> > Which came in after I applied it....
> 
> I've seen other maintainers revise commit messages before sending pull
> requests along, but I guess that's problematic as anyone else who has
> pulled before the revision would then have a merge conflict.

In general I avoid redoing commits for that reason and others and one of
the reasons why we have the Link: tag in the commit message is to be able
to look up such additional information easily - assumed that the archives
have not vanished from the planet.

Thanks,

	tglx