Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Tal Shorer <tal.shorer@gmail.com>,
        "keith.busch@intel.com" <keith.busch@intel.com>,
        "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: fabrics: fix ctrl_loss_tmo < 0 to reconnect forever
Thread-Topic: [PATCH] nvme: fabrics: fix ctrl_loss_tmo < 0 to reconnect
 forever
Thread-Index: AQHULo9IbtFW8QpLZEefyasV3okIfaS04FTY
Date:   Tue, 7 Aug 2018 22:49:47 +0000
Message-ID: <BYAPR04MB4502CA560886C1025B15A62B86270@BYAPR04MB4502.namprd04.prod.outlook.com>
References: <20180807204239.24907-1-tal.shorer@gmail.com>
In-Reply-To: <20180807204239.24907-1-tal.shorer@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d605b595-0ad1-40e2-c94e-08d5fcb813a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2018 22:49:47.4836
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3943
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good to me.

Just 's/supplics/supplies/'.

Without looking into the entire code, If we can change the type of max_reco=
nnect and nr_reconnects to unsigned int then we can just get away with the =
one comparison (ctrl->nr_reconnects < ctrl->opts->max_reconnects).

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>


From: Linux-nvme <linux-nvme-bounces@lists.infradead.org> on behalf of Tal =
Shorer <tal.shorer@gmail.com>
Sent: Tuesday, August 7, 2018 1:42 PM
To: keith.busch@intel.com; axboe@fb.com; hch@lst.de; sagi@grimberg.me; linu=
x-nvme@lists.infradead.org; linux-kernel@vger.kernel.org
Cc: Tal Shorer
Subject: [PATCH] nvme: fabrics: fix ctrl_loss_tmo < 0 to reconnect forever
=A0=20
=20
When the user supplics ctrl_loss_tmo < 0, we warn them that this will
cause the fabrics layer to attempt reconnection forever.
However, in reality the fabrics layer never attempts to reconnect
because the condition to test whether we should reconnect is backwards
in this case.

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
=A0drivers/nvme/host/fabrics.c | 2 +-
=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index f7efe5a58cc7..206d63cb1afc 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -474,7 +474,7 @@ EXPORT_SYMBOL_GPL(nvmf_connect_io_queue);
=A0
=A0bool nvmf_should_reconnect(struct nvme_ctrl *ctrl)
=A0{
-=A0=A0=A0=A0=A0=A0 if (ctrl->opts->max_reconnects !=3D -1 &&
+=A0=A0=A0=A0=A0=A0 if (ctrl->opts->max_reconnects =3D=3D -1 ||
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ctrl->nr_reconnects < ctrl->opts->max_=
reconnects)
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return true;
=A0
--=20
2.14.1


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
    =