Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp170337imm; Tue, 7 Aug 2018 16:17:58 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwd9sDXas1fxw2dTZWXjslpXOIHUKe/c78zhazTnK3GxdeG5Wcoq0xWX85ecn4LbfjWPiqJ X-Received: by 2002:a63:fd06:: with SMTP id d6-v6mr312083pgh.348.1533683878422; Tue, 07 Aug 2018 16:17:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533683878; cv=none; d=google.com; s=arc-20160816; b=W98eUo2gkHETkwAapd2WjKsepfry99yhD7NTwT6V9frlEkmuaoxHLD/bl0B0cF3KJT V0LO2fneU3ciAjYtY4w10lFUz6hc0fgcRhFnmmlJW5E6nAg4jlnfjBkW2ODscYVIAbDb vX93TZkf0PDVWX3x867Zro5FW9d1GZ0bmKJkxjYi3mtNtK+AnrvECzFjHcaHc/vtavJH fRQS6bj/epC0CfDiA+ABEbXPEcIIbT9uaCdMzxmaMPgEe/JRIlf49zJBOwcAaMGnGDPs Y4l9ezDNZg9hOKjRwiqHGbh+W/GaOnUmoo7ZpnYptn7684tNdXumzDuWv6xaR/X6xe85 pC0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=SBP1rwZ352kDitqiuCumCkXzh6tEu+cyPpLvYE/MkUE=; b=ahMGhvr67pbKJqzYW8FEbjjG3INNxgGAOGTDthrCicHE+K+iqK+qAxi4dt9ste8DKB WwEAH143QuncLUbo/USwJ2SOr026UkBwD/pRTytk8KE6YL5Y0/a3lz9h/1nYeiUr2NSQ e8iIiJO9UkmkGF0XCfyRf3+8KSO8juoLszbsOgHYk4Wr5eCyEMkujO5rVuKmjK0HBi3z ddTqmSAA+YTXZvWOYctUSOx+0bHGzBwot+vDqurr68JjhsNAZurhdt2vLaZVniTHl77U /jq/mW39WxeyLZ81LCcibyxGKTudVP2PCXAd14cbhnccFKfCCsZzWxP0/MO7fGpbcEzL Sf2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 28-v6si2461504pgk.111.2018.08.07.16.17.44; Tue, 07 Aug 2018 16:17:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbeHHBc4 (ORCPT + 99 others); Tue, 7 Aug 2018 21:32:56 -0400 Received: from gateway32.websitewelcome.com ([192.185.145.107]:13547 "EHLO gateway32.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbeHHBc4 (ORCPT ); Tue, 7 Aug 2018 21:32:56 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id A611618B0EF for ; Tue, 7 Aug 2018 18:16:14 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id nBCyf79NobXuJnBD1fWAyr; Tue, 07 Aug 2018 18:16:14 -0500 X-Authority-Reason: nr=8 Received: from [189.250.73.102] (port=48064 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fnBCx-001s8Y-LJ; Tue, 07 Aug 2018 18:16:07 -0500 Date: Tue, 7 Aug 2018 18:16:07 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Cc: linux-parisc@vger.kernel.org Subject: [PATCH 11/33] net: tulip: de4x5: mark expected switch fall-throughs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.73.102 X-Source-L: No X-Exim-ID: 1fnBCx-001s8Y-LJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.73.102]:48064 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 91 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114784 ("Missing break in switch") Addresses-Coverity-ID: 114785 ("Missing break in switch") Addresses-Coverity-ID: 114786 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/dec/tulip/de4x5.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c b/drivers/net/ethernet/dec/tulip/de4x5.c index a31b4df..66535d1 100644 --- a/drivers/net/ethernet/dec/tulip/de4x5.c +++ b/drivers/net/ethernet/dec/tulip/de4x5.c @@ -3204,6 +3204,8 @@ srom_map_media(struct net_device *dev) case SROM_10BASETF: if (!lp->params.fdx) return -1; lp->fdx = true; + /* fall through */ + case SROM_10BASET: if (lp->params.fdx && !lp->fdx) return -1; if ((lp->chipset == DC21140) || ((lp->chipset & ~0x00ff) == DC2114x)) { @@ -3224,6 +3226,8 @@ srom_map_media(struct net_device *dev) case SROM_100BASETF: if (!lp->params.fdx) return -1; lp->fdx = true; + /* fall through */ + case SROM_100BASET: if (lp->params.fdx && !lp->fdx) return -1; lp->media = _100Mb; @@ -3236,6 +3240,8 @@ srom_map_media(struct net_device *dev) case SROM_100BASEFF: if (!lp->params.fdx) return -1; lp->fdx = true; + /* fall through */ + case SROM_100BASEF: if (lp->params.fdx && !lp->fdx) return -1; lp->media = _100Mb; -- 2.7.4