Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp171122imm; Tue, 7 Aug 2018 16:19:03 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxcgaZOwJxoN/I09GX7d+NHHdH5eeZc/Pdyd7nHqMnj4YlW799gA/mgFuy7SDXu65P35d4n X-Received: by 2002:a17:902:47c2:: with SMTP id d2-v6mr301221plh.139.1533683943660; Tue, 07 Aug 2018 16:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533683943; cv=none; d=google.com; s=arc-20160816; b=TolM6rCU4+jAl9hHLoO64aZspJk7rsOD5O5LRPi24dCh7JzqSaVLOW71/ystXBP26c sUWd+iBbxn3Umeslcg35vmm1dXlV/vSxBEzHL7eJKxR3+Nk7NqqsKm0/V+BttXUMNyV8 APGlyngA3zec6hYR81Ab+1PFz3csetDGe1l0DjWijrMAPk8FCP1j1XXoc2r1x/Dt399X rzBy1kmlopAd4TuOb2OanAh91XzanzJxBCrLE2n7wmAmJbYEomhmlYQ5z6oOo97Lct/J kR34p7Gqk//NifGzCikNyGF6jipHsx2d1XtB4br9YunIk71AM51FKkV8iSuoBqwk3yQb fq8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=yR9/bUEr8l2zsmG3a9XHRj3qdcf5tN+Qq+46SUNoYU8=; b=P3K4+zR4AtsgTzZ4VYIaWu35brcvg8xP4szEMzPUypi8J+9K03LZPc9e93D+bgdrfV LgoDr8/qCLZ6MSllXLw7c0oj+zLfAPyEZboS1llFZ+wVXUpYWPlWo4wDls27qy12ZOrK B+D9jit4ihOVMBMBUNicLgp46FDpNK2Eq9jRWPuf9tXPzUqx6TV19iwiAv+usQRGfxfk LFbxY5m6sdL4t01jvvtJ6k8fyoxiRuD5fdYtRWJKCgC2KzUi5ddyb/mM90rQt7LyHdA2 3GXfbeGtmkc947zYV4vatZpUQ/+CJBd96gIIlyhjBk+2eQL0Ofd2zY1w5B8q68s5WS6V t8UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si2211894pld.36.2018.08.07.16.18.49; Tue, 07 Aug 2018 16:19:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbeHHBej (ORCPT + 99 others); Tue, 7 Aug 2018 21:34:39 -0400 Received: from gateway21.websitewelcome.com ([192.185.45.228]:23348 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbeHHBei (ORCPT ); Tue, 7 Aug 2018 21:34:38 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 6FBEB400D4AF8 for ; Tue, 7 Aug 2018 18:17:56 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id nBEdf7EU8bXuJnBEgfWG70; Tue, 07 Aug 2018 18:17:56 -0500 X-Authority-Reason: nr=8 Received: from [189.250.73.102] (port=48076 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fnBEc-001szb-QE; Tue, 07 Aug 2018 18:17:50 -0500 Date: Tue, 7 Aug 2018 18:17:50 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Cc: Yisen Zhuang , Salil Mehta Subject: [PATCH 13/33] net: hns: Mark expected switch fall-through Message-ID: <674c750536890e504eb80242ee65fc024419ba20.1533675546.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.73.102 X-Source-L: No X-Exim-ID: 1fnBEc-001szb-QE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.73.102]:48076 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 102 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114788 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 3957205..08f3c47 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -307,6 +307,7 @@ static int __lb_setup(struct net_device *ndev, break; case MAC_LOOP_PHY_NONE: ret = hns_nic_config_phy_loopback(phy_dev, 0x0); + /* fall through */ case MAC_LOOP_NONE: if (!ret && h->dev->ops->set_loopback) { if (priv->ae_handle->phy_if != PHY_INTERFACE_MODE_XGMII) -- 2.7.4