Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp173218imm; Tue, 7 Aug 2018 16:22:08 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyCiMCFNW4etRcAWzxQu7oScfcFMfbEByaeTOJ3Y6MN6Ti3V6hxeUEU9o/RNxl4AVIUTtGp X-Received: by 2002:a63:d002:: with SMTP id z2-v6mr323980pgf.262.1533684128138; Tue, 07 Aug 2018 16:22:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533684128; cv=none; d=google.com; s=arc-20160816; b=f+cCN/lGXMKDXg3msvzjE/YmVXQUnS15sybXkLok2Vjxbct5fv97EUbBEj9Atzlesp J5EMJb36Cq/Zj9kpcGHNMtVRKdavgYrCaZZgTouEvXjANmyJSWzbwV5dpynl8fRw2tmu c0ovBEQ+LGZoc29/u+JAKJ5f4dDetsYkcIlA/QHIUL3oIyAyvEpakz0yMzpaDTrI22is 4t8MoXRzcv2BiCZz5e5LegVhQnNVM25anRHvDc3QY+uA4nNQgpe7KhvCaCtIDtMfm3iX qk+ybhznQ8NBNJSitCped5MOSet5eHqCxzX904l5EowCFvk3FZ8Wz7T3CVUEtolwHqFu mRBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=LM2F+EHEW3EfS/DRAqGZz88b1h50GM+Ux8m1uGR0LhY=; b=Z7B9BQbAO9KpjYGN15xrnd9qLc7H79AzdXcC1BlDnNqTjXU/xPP/dadyg1xIf0n0o+ zcUPJXzyxw1YZqw2IY+X+aArfzxnDYj31bmWb06pxBKtffN+4ipOKlfkA1Wf4WgMLL+p p69pZniC6E3GH4FNKPvEIRq3iwUhtvIOFodCAAlfl2A8B9gLZyvzNSKMy3+lzlnISmAU o8eUpp+EknZzUI2pdbW0rhjsEufJFhJ91pUcXwZgwJK8EX/ZmzDn+NHXvZi3perqSV9V pVVPNW7DXJ4ynQzC/wunxJyWS6V4H3jxVcvGRCkbIe6gDY3RgwmIist6BsGTE9nuhExo FcEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 10-v6si2145407ple.60.2018.08.07.16.21.54; Tue, 07 Aug 2018 16:22:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727411AbeHHBhL (ORCPT + 99 others); Tue, 7 Aug 2018 21:37:11 -0400 Received: from gateway24.websitewelcome.com ([192.185.50.91]:30882 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727061AbeHHBhL (ORCPT ); Tue, 7 Aug 2018 21:37:11 -0400 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id AB724C0A2 for ; Tue, 7 Aug 2018 18:20:28 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id nBHAf62pqPvAdnBHAf7NIU; Tue, 07 Aug 2018 18:20:28 -0500 X-Authority-Reason: nr=8 Received: from [189.250.73.102] (port=48084 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fnBHA-001uLA-3K; Tue, 07 Aug 2018 18:20:28 -0500 Date: Tue, 7 Aug 2018 18:20:27 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Cc: Jeff Kirsher , intel-wired-lan@lists.osuosl.org Subject: [PATCH 16/33] i40e_txrx: mark expected switch fall-through Message-ID: <7997bf34df88375f097d0a7d60608620718e81db.1533675546.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.73.102 X-Source-L: No X-Exim-ID: 1fnBHA-001uLA-3K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.73.102]:48084 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 117 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114791 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index b151ae3..b5042d1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -2253,9 +2253,10 @@ static struct sk_buff *i40e_run_xdp(struct i40e_ring *rx_ring, break; default: bpf_warn_invalid_xdp_action(act); + /* fall through */ case XDP_ABORTED: trace_xdp_exception(rx_ring->netdev, xdp_prog, act); - /* fallthrough -- handle aborts by dropping packet */ + /* fall through -- handle aborts by dropping packet */ case XDP_DROP: result = I40E_XDP_CONSUMED; break; -- 2.7.4