Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp177263imm; Tue, 7 Aug 2018 16:28:07 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzgeeZovnXMmcDCmtBo+1vLfD5D9B8sHyr2KE94cJ+P82b6l5gMAgZApLGoQ2TF3raGOwHD X-Received: by 2002:aa7:8087:: with SMTP id v7-v6mr412921pff.38.1533684487864; Tue, 07 Aug 2018 16:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533684487; cv=none; d=google.com; s=arc-20160816; b=eIuL2NbGyBBh+BBamp8fSViBke1W/4LEW6CDlA75cRpZ6T80Ilr9IUeMHVI8xOna/k y7zCWxKI/JrCrjhezIqo4+lo9Fq6CquR8H0huAzo4tnJ0eunnYpIHaEOQFu6yrLx5K/j UysPy58G1YXzF4NRYvZJUMtn9fVkWLpWlDpRFYjmhfADZCQZnU0orgRu3sPDK0IdSVmJ BZ2vY83WFaJ61NJHXU4diUFn+7FRaarD5Xoq0b39Tj/tONcPI90iVUkcPOGw3Lzykdtz SjGFREhuKp0b/evIeo5McZHfSkzvpqtjiULhxbnEaTBR7+tSBe+eT4urVOuqeFNuDBZ+ r5Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=rPWfTQUC3gN/uOJ7vmK32Z/o714mpPrermrQJBL4QTs=; b=V/BFgIU0TWoaHGv9y4/n7F/UYFhQH4RtwV6CWj4IqBL9As+EcAypKMrVZrTOai7Y3f 7QoFXL91G6pUow2HBwb92J/cBFO0qVMnVDMP6mjaEOocTGK6zYFs+4Gr9oKnyJR1RU8V KTdN6DvEpHpbi+F9KWVPEZKYLAcCKChhS2Z4CNQmUCb38bonARwvroGq2julpYE5Q8Lc EvqVa6Z3V8R7pNz5fPTpup3MxS3zjXSJz6UcuMqTLazacn/t6+JL/apvYRhyLH4o/RSe 1e1CjUggqolgI6RiD0Y79xCDpycaLj4XHGOwzHS13glDrYOEiThh71auRhI9fU3KZKWx NB7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c22-v6si2045146plo.271.2018.08.07.16.27.53; Tue, 07 Aug 2018 16:28:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727475AbeHHBnh (ORCPT + 99 others); Tue, 7 Aug 2018 21:43:37 -0400 Received: from gateway34.websitewelcome.com ([192.185.150.114]:15151 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726998AbeHHBnh (ORCPT ); Tue, 7 Aug 2018 21:43:37 -0400 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 7CEC51CEAA for ; Tue, 7 Aug 2018 18:26:52 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id nBNLfje7vBcCXnBNLfJg1L; Tue, 07 Aug 2018 18:26:52 -0500 X-Authority-Reason: nr=8 Received: from [189.250.73.102] (port=48126 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1fnBNK-001xHK-GM; Tue, 07 Aug 2018 18:26:50 -0500 Date: Tue, 7 Aug 2018 18:26:49 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Cc: Manish Chopra , Rahul Verma , Dept-GELinuxNICDev@cavium.com Subject: [PATCH 26/33] netxen_nic: Mark expected switch fall-throughs Message-ID: <27059b065b37c33381219fba31648f7d0d565d39.1533675546.git.gustavo@embeddedor.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.73.102 X-Source-L: No X-Exim-ID: 1fnBNK-001xHK-GM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.73.102]:48126 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 167 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1410182 ("Missing break in switch") Addresses-Coverity-ID: 1410183 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c index 3157f97..3c1be87 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ethtool.c @@ -167,9 +167,9 @@ netxen_nic_get_link_ksettings(struct net_device *dev, case NETXEN_BRDTYPE_P3_REF_QG: case NETXEN_BRDTYPE_P3_4_GB: case NETXEN_BRDTYPE_P3_4_GB_MM: - supported |= SUPPORTED_Autoneg; advertising |= ADVERTISED_Autoneg; + /* fall through */ case NETXEN_BRDTYPE_P2_SB31_10G_CX4: case NETXEN_BRDTYPE_P3_10G_CX4: case NETXEN_BRDTYPE_P3_10G_CX4_LP: @@ -198,6 +198,7 @@ netxen_nic_get_link_ksettings(struct net_device *dev, supported |= SUPPORTED_TP; check_sfp_module = netif_running(dev) && adapter->has_link_events; + /* fall through */ case NETXEN_BRDTYPE_P2_SB31_10G: case NETXEN_BRDTYPE_P3_10G_XFP: supported |= SUPPORTED_FIBRE; -- 2.7.4