Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp593008imm;
        Wed, 8 Aug 2018 02:15:03 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPzQnBShHiZ/B35xNYeCJwUQc0NSFuDviE5LjID89Luck8RAVHkJlRJg6SOo7wLuv5Zlpfew
X-Received: by 2002:a63:4924:: with SMTP id w36-v6mr1758404pga.143.1533719703733;
        Wed, 08 Aug 2018 02:15:03 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1533719703; cv=none;
        d=google.com; s=arc-20160816;
        b=ZiZOVlf+xJ6sD8od2Ukk1c3G89w/Kx3Kp9x4BqrZn5alJ+C64bMfW9KvMje3s/jDq4
         uncQKsB4lgibdkRXfy0AbggYUVdU7ZmkR2htDrIHK0836nJ50AN36WmaKJaOml52f/7K
         vHTjI+yWGqIxNPeMTBT1plnZMZ6qgenQp2wcRuTNKZkcbM2nT0qlSit8srqgedvNXWNr
         C1E8yncKxdC/bcIbpiPZm8zBwrPL4k8pLZllC/RWVxybLZUhxcoC5yf1LEkoB3CGKsZB
         CU6c3KnkDmuPSlyz9RaCvE6+nyLc2aBqztpVBmWEX0CKvIoOIYvH8gJRsurHsqB4TAy5
         1rAA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :references:in-reply-to:mime-version:arc-authentication-results;
        bh=LpD05EKk7VqUzNzSz+INgqNmnWxOWd/ZHOPbpWr4VFU=;
        b=WZHyEGxws4KPdEkeZyxTrLqzetyh6F0HNWiuuJhbtmWyRC1MD7V5z2Z5Fqiy2saS+6
         OOpLclrU8N8adFNofaKjNrmPdQ1MRZPkJRXqccUPW4EYo5uG8cN/4l23i6QTuVFrQJQu
         mibpaf5jhlEi0gWd20xYRyoc/dCDjJmUsLtRu9s4ShZJw72OLcRZXOLcYj7yQKh6S/Ku
         vlcaCc+ggtjrGENc4QmnswpbKonnqqZ4xeILT0qBWrwi6CUx1ykQ/PdLFzglMNeE+i/1
         Z2RNASVjk0XvLxmpfaoq92apS0z5sFw+rjnUgRNNJ65l1PVCVlh1JmxUO1WNcivtScEO
         szWg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z15-v6si3881679pgf.293.2018.08.08.02.14.49;
        Wed, 08 Aug 2018 02:15:03 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727336AbeHHLcS (ORCPT <rfc822;marvinzhang.kernel@gmail.com>
        + 99 others); Wed, 8 Aug 2018 07:32:18 -0400
Received: from mail-ed1-f66.google.com ([209.85.208.66]:37292 "EHLO
        mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727174AbeHHLcS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Aug 2018 07:32:18 -0400
Received: by mail-ed1-f66.google.com with SMTP id b10-v6so908232eds.4;
        Wed, 08 Aug 2018 02:13:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=LpD05EKk7VqUzNzSz+INgqNmnWxOWd/ZHOPbpWr4VFU=;
        b=gDSkhwBDy21k4vJKxvFpvYdRDWnKX6SOMCGmyL8i5o5Fx211sNyp+ySk1nMYBaFv0V
         1tjfhzlbmT8MFMDldCUOWZu+KhRZVuazk4Z3KUBGn5BzAIoJMUbt1DRx/5aiixPhtpsq
         j93evf0+6SmAkSw7TDpxRdzTrGtPQ6ez5PDzt7OVFFHyiVUWLYGQar+gB6prLh1J1GqV
         LlXqRFOFDaKxW4JYVAaOBTtNaWdlPW/AEiStLXTaOVZlgIvgNXl1syvzrpINK59X0z3f
         Zst/VHVV8xM94a2bljENDmed7BRK878qSvRrzjDFBlpqd0vFMjqvWdb3xhnNkiDENlgu
         D0Fg==
X-Gm-Message-State: AOUpUlHiYPWFY3FyPiKVXoQct9HGifNqkM43VCcWIM3R6Q5AA7v1fJRY
        Pq+EHhMYma9kIyl83VUqaxT/giUdQpM=
X-Received: by 2002:a50:a2a6:: with SMTP id 35-v6mr2340076edm.276.1533719608873;
        Wed, 08 Aug 2018 02:13:28 -0700 (PDT)
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com. [74.125.82.42])
        by smtp.gmail.com with ESMTPSA id j23-v6sm2180447edh.29.2018.08.08.02.13.28
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 08 Aug 2018 02:13:28 -0700 (PDT)
Received: by mail-wm0-f42.google.com with SMTP id y9-v6so1971128wma.5;
        Wed, 08 Aug 2018 02:13:28 -0700 (PDT)
X-Received: by 2002:a1c:6fdd:: with SMTP id c90-v6mr1271322wmi.16.1533719608030;
 Wed, 08 Aug 2018 02:13:28 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:adf:a101:0:0:0:0:0 with HTTP; Wed, 8 Aug 2018 02:13:07 -0700 (PDT)
In-Reply-To: <20180806160635.9293-1-vasilyev@ispras.ru>
References: <20180806160635.9293-1-vasilyev@ispras.ru>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Wed, 8 Aug 2018 17:13:07 +0800
X-Gmail-Original-Message-ID: <CAGb2v6481_8sxGzpfzgi7J61OWDw6YFou4Lc3ve4qDTdNM0ayA@mail.gmail.com>
Message-ID: <CAGb2v6481_8sxGzpfzgi7J61OWDw6YFou4Lc3ve4qDTdNM0ayA@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: axp209: Fix NULL pointer dereference after allocation
To:     Anton Vasilyev <vasilyev@ispras.ru>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        ldv-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 7, 2018 at 12:06 AM, Anton Vasilyev <vasilyev@ispras.ru> wrote:
> There is no check that allocation in axp20x_funcs_groups_from_mask
> is successful.
> The patch adds corresponding check and return values.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>

Acked-by: Chen-Yu Tsai <wens@csie.org>