Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp750377imm; Wed, 8 Aug 2018 05:14:53 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxl0gwII8caxwQXzM0Fez9Ei3oByBP4zWj4QXpRgjrNa3WI+W4gd/gFu/EFx66FvAE06y7F X-Received: by 2002:a62:7983:: with SMTP id u125-v6mr2688730pfc.177.1533730493522; Wed, 08 Aug 2018 05:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533730493; cv=none; d=google.com; s=arc-20160816; b=0+IrQTeZZpMgOYRyFYe/tYPV1Q1/F8dfZZDLBxCJVxTez6SWxacpzAULyAR6fAgXeM IBcl5v1sJrr0f3BesFUsMfDDxUOEJkJXhXKP2PBd+IcymhL2aydCvkskU4qBixTVQLlw EUd6A8EDNvu1IQmOpUQ3hl4ROvWcfoM5/p9JhZhnj2eh1Cw0HPYWc/67FricpWNX/w4J K1ANHk63X9IgRrCYiqYH6Eobjka60Ej5CkZI/UoxLyBOLXgXqT8qysJqX/+4cY8g1PFf GwmctdCWinfExuXhRnkE9+b547zKZP/XeiRmcEQhl/ISV34yGeY7eXvGH0ka1Jl85PZ/ iyVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=Z3Sy4hLe7u9nqOHXocZfNWynoSjvwdxZd/AkfzO9ioA=; b=XMoW0z+Z7qWILKdmmEdqbAmaFXvXkuCYTZVNgFuoB2d58UN31d/JCOtKG6V/QmEhEk Lz/sJKwk6Szr32aY+ooXS8zzZ76XyfLJfqsCNJ746nYDIu2K/eqw2hC28Tq1ia98G2np xlxV6oJlmHxwYcKerD7kiCszg/eZp40aNI6VDl4qwCeSk3DnuLr88payUgqOWv60Qfmh G1bAb+lou/+6xsJubAzCWlDGPNW+c50rgmHa80zmaTEn4RMQXDhMX9COg2tRmY7mhT9n XH2bZpXtriizc3hRRpz6TahhxafNSKM5r9NyW2qqmMKhPxb/3YnMGRD5S6Qo94s1zoz1 dcxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 38-v6si4146753pgz.286.2018.08.08.05.14.39; Wed, 08 Aug 2018 05:14:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbeHHOc5 (ORCPT + 99 others); Wed, 8 Aug 2018 10:32:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34548 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbeHHOc4 (ORCPT ); Wed, 8 Aug 2018 10:32:56 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w78CAMwO144068 for ; Wed, 8 Aug 2018 08:13:31 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kqyt5scj7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 08 Aug 2018 08:13:31 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Aug 2018 13:13:28 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 8 Aug 2018 13:13:26 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w78CDOn138404266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Aug 2018 12:13:24 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ECEADAE045; Wed, 8 Aug 2018 15:13:17 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A6EBAE053; Wed, 8 Aug 2018 15:13:17 +0100 (BST) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 8 Aug 2018 15:13:17 +0100 (BST) From: Ursula Braun To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, raspl@linux.ibm.com, linux-kernel@vger.kernel.org Subject: [PATCH net 1/3] net/smc: no shutdown in state SMC_LISTEN Date: Wed, 8 Aug 2018 14:13:19 +0200 X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180808121321.516-1-ubraun@linux.ibm.com> References: <20180808121321.516-1-ubraun@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18080812-0020-0000-0000-000002B3E90B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18080812-0021-0000-0000-00002100F601 Message-Id: <20180808121321.516-2-ubraun@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-08_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808080126 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Invoking shutdown for a socket in state SMC_LISTEN does not make sense. Nevertheless programs like syzbot fuzzing the kernel may try to do this. For SMC this means a socket refcounting problem. This patch makes sure a shutdown call for an SMC socket in state SMC_LISTEN simply returns with -ENOTCONN. Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 05e4ffe5aabd..1288c7bf40d5 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1397,8 +1397,7 @@ static int smc_shutdown(struct socket *sock, int how) lock_sock(sk); rc = -ENOTCONN; - if ((sk->sk_state != SMC_LISTEN) && - (sk->sk_state != SMC_ACTIVE) && + if ((sk->sk_state != SMC_ACTIVE) && (sk->sk_state != SMC_PEERCLOSEWAIT1) && (sk->sk_state != SMC_PEERCLOSEWAIT2) && (sk->sk_state != SMC_APPCLOSEWAIT1) && -- 2.16.4