Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp758974imm; Wed, 8 Aug 2018 05:23:58 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwSnbqhg9GVJFK5WiJ0X8FSxh4ZPnvfMF4dbfwv/zxOSgAXncqGBXFoWghDTaNDMP+NmhFP X-Received: by 2002:a17:902:a713:: with SMTP id w19-v6mr2378126plq.271.1533731038891; Wed, 08 Aug 2018 05:23:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533731038; cv=none; d=google.com; s=arc-20160816; b=OWKmFPfkaIMVYJqV+pQtIQLfv2hXH/Uy50QhtX0lBgS2ksRe3zxP5dfucZ3lfukRht elIQ0LJaityd8pJuvKun1ODXDq4rozRQx4Ba6aYnEZJTRvYWH5KxPZfMHOAzJTUUpmWM YuYjPog8bAtZVR4Q9naBNvwRjVHGk9tC1mkNxFgiK49V496JttG/K6bwMLxHyuLHtPvg X8vwKqej63X9GQgufdTJv4nNXvKIYhpXHDdNMVSvcETLm6SiyDYv3+0j0X012FQEzwP0 VJM4FYLyFx3R1dBil7TfW6jTjVwQgbaw8oTRjV1lTqyKmI/+e+lz823Zc7Q3VZqUXkQE DdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=1qi+VWSfdKnALkMKpAuUAO/I7sUUWvONyTh/WFwDhO4=; b=gANhqWO4luIgL0DyF36AYk+bB6BIrQw3uSNqPMVhfkBo5e2fKAlj2DKfgoPRQdDcd9 xJY5GlTjs/NjmFqs7lFGMCTBK3lLEnzy2uAGxMP7UYYDmhgdDL0ZEBzilTe3h7ANzwgO NesY1j4/VAMOy/Z8fhhYGWp1PBdd8sP14v3ee9nli2AWvGRpq5j1u9raY3bgvQGEvcIQ SmrzN69RdzrpMUma2WIR5Aes07HB6p0J5sjJs5+tx5cPy6AqwIrMlXbaAowN8Fy1x/WE iuKYiZ7LWOG9CDLRyOgInTLSI2PwAdDynez9N7EkLQMJPHBhRu7MoNnZxlTjv2fCB31g T86Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j19-v6si3997574pgg.313.2018.08.08.05.23.44; Wed, 08 Aug 2018 05:23:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbeHHOmI (ORCPT + 99 others); Wed, 8 Aug 2018 10:42:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41268 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbeHHOmI (ORCPT ); Wed, 8 Aug 2018 10:42:08 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id AADD7CE7; Wed, 8 Aug 2018 12:22:40 +0000 (UTC) Date: Wed, 8 Aug 2018 14:22:37 +0200 From: Greg Kroah-Hartman To: Leonardo =?iso-8859-1?Q?Br=E1s?= Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/15] staging: fbtft: Includes description to mutex and spinlock - Style Message-ID: <20180808122237.GD20272@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 09:29:31PM -0300, Leonardo Br?s wrote: > Includes description to mutex and spinlocks, as recommended by checkpatch.pl. > > Signed-off-by: Leonardo Br?s > --- > drivers/staging/fbtft/fbtft.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h > index 6ee9ff320567..f771271d497a 100644 > --- a/drivers/staging/fbtft/fbtft.h > +++ b/drivers/staging/fbtft/fbtft.h > @@ -203,7 +203,7 @@ struct fbtft_par { > u8 *buf; > u8 startbyte; > struct fbtft_ops fbtftops; > - spinlock_t dirty_lock; > + spinlock_t dirty_lock; /*Protects dirty_lines_{start,end}*/ Why no spaces in your comment? thanks, greg k-h