Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Aug 2018 08:24:12 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Liu, Changcheng" <changcheng.liu@intel.com>
Cc:     broonie@opensource.wolfsonmicro.com,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget
Message-ID: <20180808082412.20f7bd92@gandalf.local.home>
In-Reply-To: <20180808092927.GA144203@sofia>
References: <20180808092927.GA144203@sofia>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 8 Aug 2018 17:29:27 +0800
"Liu, Changcheng" <changcheng.liu@intel.com> wrote:

> Track snd_soc_dapm_widget:id which is used as dapm
> sequence index in dapm_down_seq/dapm_up_seq. It's
> useful for checking dapm seq after tracking it.
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> 
> diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h
> index 40c300f..0bc935b 100644
> --- a/include/trace/events/asoc.h
> +++ b/include/trace/events/asoc.h
> @@ -92,16 +92,18 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_widget,
>  
>  	TP_STRUCT__entry(
>  		__string(	name,	w->name		)
> +		__field(	int,	id		)
>  		__field(	int,	val		)
>  	),
>  
>  	TP_fast_assign(
>  		__assign_str(name, w->name);
> +		__entry->id = w->id;
>  		__entry->val = val;
>  	),
>  
> -	TP_printk("widget=%s val=%d", __get_str(name),
> -		  (int)__entry->val)
> +	TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> +		  (int)__entry->id, (int)__entry->val)

Not sure why it was there before, but the (int) typecast isn't needed
in either case. __field(int, val) makes __entry->val of type int. Same
for id.

-- Steve

>  );
>  
>  DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_power,