Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp760682imm; Wed, 8 Aug 2018 05:25:50 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw0FNzZ6Vp3sT7Nr65/3qAkryoQNZRouQyHFfqmczxBDuuLNS57Drzw18ofujFkI5fgteha X-Received: by 2002:a63:b256:: with SMTP id t22-v6mr2451512pgo.101.1533731150640; Wed, 08 Aug 2018 05:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533731150; cv=none; d=google.com; s=arc-20160816; b=A/zJ8bMDJah3/wMExPF7bPAXM1jmATjXJGQd+7FD89O8OK2Hn8scR2ndlTudu/45G/ gZV/V3ZfjQLEBQY956hRqU3nXHglS3Dm7qAhu9M3mPnioGjISwH9iH8klXg1uVKjC0nC srOFFJeu6zTs61lcrX5KTMlmT8YU2nvV4Q0lW5yu/uX2QgyouU1zrzCEKu7Qw8OlftmF WZrWjJ+R39XkN5OB7qXJ9EdtL/0J9WITau2FN3YlNQCtjUgb1CqYuhuANQvvSnmKqfcm yMWC5rrTPDSVeapq9zyotUT5XKVWNklx3oTZrIok24nNWAEJBWjiK34E4eWjUMv6VLs/ wS0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=bA7q1puZ2pbwp9NRog3qO3Lk0/RzaIVG63De5Vv4ZXY=; b=qhFnaw4oeri1Uy9auo5zPX6kbX+2Qh/iH4p2Unoo8IyCK4YQ4Tl+ktsEjueRtrjZzq wYzB48HXHrbvOYorgezRJHz4ImDdJwZgY3yHZZB+O0nOj10xtVH2JN3UfvLKWhTAUvbl awHAl5d4tDSbrUIDxO+E9UhXIQE5HAc9XkUcmeFkWYbYCN/R0QWR1i2v0N16RbjEVnvZ JmJc6C0P9x7HY0Sou/8x7kPEFDbeKA/2mfjfQdiGYpT+tqUYy2f56DCHuTkBTmFK7xlq YkYP1Z20DyDc3Azon3GVW55ez6M9OOQQ2lfigp+2XrjvFDArkPQlTW6a+ITuIkNbO5iW 3FdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q66-v6si4320754pfk.268.2018.08.08.05.25.35; Wed, 08 Aug 2018 05:25:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727087AbeHHOn7 (ORCPT + 99 others); Wed, 8 Aug 2018 10:43:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41292 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbeHHOn7 (ORCPT ); Wed, 8 Aug 2018 10:43:59 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 4D385CC1; Wed, 8 Aug 2018 12:24:31 +0000 (UTC) Date: Wed, 8 Aug 2018 14:24:28 +0200 From: Greg Kroah-Hartman To: Leonardo =?iso-8859-1?Q?Br=E1s?= Cc: Thomas Petazzoni , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/15] staging: fbtft: Replaces custom debug macro with dev_dbg(). Message-ID: <20180808122428.GA22383@kroah.com> References: <8de0b9b85209f4b4a3c8f0f84188a0ee0964bf44.1533686201.git.leobras.c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8de0b9b85209f4b4a3c8f0f84188a0ee0964bf44.1533686201.git.leobras.c@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 07, 2018 at 09:30:10PM -0300, Leonardo Br?s wrote: > Changes custom macro to dev_dbg to avoid parameter multiple usage and use of typeof(). linewrap please. And while this is a good start, please replace the places this custom macro is called with dev_dbg(), and then delete this macro. Don't extend its life with a change like this :( thanks, greg k-h