Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Aug 2018 20:39:22 +0800
From:   "Liu, Changcheng" <changcheng.liu@intel.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     broonie@opensource.wolfsonmicro.com, mingo@redhat.com,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget
Message-ID: <20180808123921.GA145536@sofia>
References: <20180808092927.GA144203@sofia>
 <20180808082412.20f7bd92@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180808082412.20f7bd92@gandalf.local.home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08:24 Wed 08 Aug, Steven Rostedt wrote:
> On Wed, 8 Aug 2018 17:29:27 +0800
> "Liu, Changcheng" <changcheng.liu@intel.com> wrote:
> 
> > Track snd_soc_dapm_widget:id which is used as dapm
> > sequence index in dapm_down_seq/dapm_up_seq. It's
> > useful for checking dapm seq after tracking it.
> > 
> > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> > 
> > diff --git a/include/trace/events/asoc.h b/include/trace/events/asoc.h
> > index 40c300f..0bc935b 100644
> > --- a/include/trace/events/asoc.h
> > +++ b/include/trace/events/asoc.h
> > @@ -92,16 +92,18 @@ DECLARE_EVENT_CLASS(snd_soc_dapm_widget,
> >  
> >  	TP_STRUCT__entry(
> >  		__string(	name,	w->name		)
> > +		__field(	int,	id		)
> >  		__field(	int,	val		)
> >  	),
> >  
> >  	TP_fast_assign(
> >  		__assign_str(name, w->name);
> > +		__entry->id = w->id;
> >  		__entry->val = val;
> >  	),
> >  
> > -	TP_printk("widget=%s val=%d", __get_str(name),
> > -		  (int)__entry->val)
> > +	TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> > +		  (int)__entry->id, (int)__entry->val)
> 
> Not sure why it was there before, but the (int) typecast isn't needed
> in either case. __field(int, val) makes __entry->val of type int. Same
> for id.
> 
> -- Steve

@Steve: This patch aims at tracking the dapm up/down sequence. For the
(int) typecast format problem, what do you think of using another
seperate patch to resolve it?

-- Changcheng
> 
> >  );
> >  
> >  DEFINE_EVENT(snd_soc_dapm_widget, snd_soc_dapm_widget_power,
>