Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Aug 2018 08:53:01 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     "Liu, Changcheng" <changcheng.liu@intel.com>
Cc:     broonie@opensource.wolfsonmicro.com, mingo@redhat.com,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] ASoC: trace: track dapm type in snd_soc_dapm_widget
Message-ID: <20180808085301.2b0617c6@gandalf.local.home>
In-Reply-To: <20180808123921.GA145536@sofia>
References: <20180808092927.GA144203@sofia>
        <20180808082412.20f7bd92@gandalf.local.home>
        <20180808123921.GA145536@sofia>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 8 Aug 2018 20:39:22 +0800
"Liu, Changcheng" <changcheng.liu@intel.com> wrote:

> > > -	TP_printk("widget=%s val=%d", __get_str(name),
> > > -		  (int)__entry->val)
> > > +	TP_printk("widget=%s dapm_id=%d val=%d", __get_str(name),
> > > +		  (int)__entry->id, (int)__entry->val)  
> > 
> > Not sure why it was there before, but the (int) typecast isn't needed
> > in either case. __field(int, val) makes __entry->val of type int. Same
> > for id.
> > 
> > -- Steve  
> 
> @Steve: This patch aims at tracking the dapm up/down sequence. For the
> (int) typecast format problem, what do you think of using another
> seperate patch to resolve it?

Yeah, I was just commenting on that as a general comment. It doesn't
affect the actual patch, which I don't see anything wrong with it from
a tracing point of view.

I agree the typecast removal should be done in a separate clean-up
patch.

-- Steve