Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp941089imm; Wed, 8 Aug 2018 08:11:37 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyCwUIEwVUnsy8rRM8hkZ4OEQt1UApNxYyuaTeim8A1YlgMGegVydmAuPtBedqKcFRVgrru X-Received: by 2002:a63:1d5e:: with SMTP id d30-v6mr3052032pgm.12.1533741097609; Wed, 08 Aug 2018 08:11:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533741097; cv=none; d=google.com; s=arc-20160816; b=gAHMiwkm9LMXye35Xd0nTKHbefhHxa5jJCJDMFB00oG0Yq9vhYS/k4Tr40773yWTjW mHrHfTLK9qoXpUlVWCCe5cwj25h23f89MQNOSSbcBqgZ2oj4DD2pkYrCx3Oa+n8K4qIA woZei1LJ4KiIyCUtYKTa+JyZj0HLB0OWl9FBFMDkXufD8WblSrVX7GyGa4lbTUjJRLTo /5ybSqaXzcb443Ub3P/3wBRmGJ3yw5egqSQSEqmtUuFEMJ6xW5qpN9cNZhZKiktJrVUc PQRQ2AadEUdu/py/1B0yvewDXXNCT66Pxm2cQmE4p7dm9WSkLJpR8LhcEyxGiUshY2Px IE1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=il8zM3pnng+5gPJRcqGhmXkiN2JaFJTFu9EhGzBqZBk=; b=IXKXEX/U7x7VaumP/cp5DlxgywH7DjLo3AyzwHiE4/6IGpIU3b+OvogqujHN04uQrW Xmcan9U3HZJ7mg5T0gBVFpb5OUWq6mzNeO57ynE0rytc0aR/RfpLxVdiCBMxUNUNuy9q wcpyCFeyCqYLq80oa1Hk5SdyJDzgLbnQ5Rjjm3jLrJ260W8WWuNLmjtr3mKufZmBKEo8 5Rn751uFuwWoPdDUHObUPDsK7vpwIt3+dDYrLQg3LtHRQui4Ca2wGR61rngXVP2MhATv xOW4soeGo2J7qEiNJD9ovIUNgAQChNPY+iWwJDWyvVcbBpwHBkPFrttbAhhhFIB2/d+Q REkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19-v6si4413790pgb.196.2018.08.08.08.11.22; Wed, 08 Aug 2018 08:11:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbeHHRa3 (ORCPT + 99 others); Wed, 8 Aug 2018 13:30:29 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:10683 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727069AbeHHRa3 (ORCPT ); Wed, 8 Aug 2018 13:30:29 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9DD0EAE03F048; Wed, 8 Aug 2018 23:10:19 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.399.0; Wed, 8 Aug 2018 23:10:16 +0800 From: zhong jiang To: , , CC: Subject: [PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive Date: Wed, 8 Aug 2018 22:58:33 +0800 Message-ID: <1533740313-11906-1-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org debugfs_remove_recursive has taken null pointer into account. So it is safe to drop the null check before calling the funtion. Signed-off-by: zhong jiang --- drivers/block/mtip32xx/mtip32xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 2b6d6bc..d0666f5c 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -2574,8 +2574,7 @@ static int mtip_hw_debugfs_init(struct driver_data *dd) static void mtip_hw_debugfs_exit(struct driver_data *dd) { - if (dd->dfs_node) - debugfs_remove_recursive(dd->dfs_node); + debugfs_remove_recursive(dd->dfs_node); } /* -- 1.7.12.4