Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp948644imm; Wed, 8 Aug 2018 08:18:13 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzalKdUPgM/jJP3k6Ufq7BiWlAsnh8Xmebzmj4LF2yloqQVjDdAiSKVEdBfXXZV9D9az490 X-Received: by 2002:a63:e116:: with SMTP id z22-v6mr2888057pgh.89.1533741493298; Wed, 08 Aug 2018 08:18:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533741493; cv=none; d=google.com; s=arc-20160816; b=zagx9f1USKDO6sZFh8fc7ZtJnJ8ywpuc+9NevA+srvARdeX199FtvGkS4v7m2LxbPq QVE4Z3eX4EIIe9AiEjn0WBdNXzP/bU8WY1uAomFv33k3TB4qM8nbW5HTbepVJQAq05Ze mXd4eaLDTzP/7Mg6DG6RxCVn5mp9AQ50uHotp/KipKLBgrCIdvlQOoDxrMdAgn+X+WwW w6jEFJlPZEZH6NN6AZ4U5cSwuJbKMEqTJk/x2FBuHM5gNdxg9SuQt+/U1CXFRhkQhP6Q pMFJVPE/ghPGl0WfmxZyLujlIUg0wsA209PQ46ne2Qvjhzy49HFh5LW6AAy3hXhWrYnd ZBtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=X7DWBcxQ3dg/kAzLTqAGXgHx+yLDtJdPTHYNmGO0asw=; b=u8jfqjBPSuRBgMVec91UaTevFqGzPTHNq/Oxi62X57kHK1hNGYNN7F4XLgekIaI+vq BMbk75BMAx2EiAlSDV6ej750rf98v/dV3qMabTA44aoOi6Y5P4y59GomS2jc7J2yGv9n BuYliAIswOLQOSlD3hD58xm49i56J9UD5R+4wJUFLb33tz1xHJYFBTqvynF9dT0d5L17 60ULbQybCPO0tN1PowxQRROF5m/TF6yV0/JZibZOvM/3Zf+W1rAWCH+NqBe/1TTSsh/R 0M2cuNTysPpc+GCWZ1jhbKPRepbJ6sxFZ6i9z/jBNL5C+KlX/SAsl6fb5xrru/tt/irp kSGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="jQD4/SbY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4-v6si4257581pgl.139.2018.08.08.08.17.58; Wed, 08 Aug 2018 08:18:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="jQD4/SbY"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbeHHRhC (ORCPT + 99 others); Wed, 8 Aug 2018 13:37:02 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:53076 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbeHHRhC (ORCPT ); Wed, 8 Aug 2018 13:37:02 -0400 Received: by mail-it0-f67.google.com with SMTP id d9-v6so3950520itf.2 for ; Wed, 08 Aug 2018 08:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=X7DWBcxQ3dg/kAzLTqAGXgHx+yLDtJdPTHYNmGO0asw=; b=jQD4/SbYLvVbqgRGS/nyVgQdo98deefD/wlJqULPXLNHC2d413Bzn81S1wACD3yCmR s0uPbe5Es9nS7lCXQeE1x6DB+0HehGglYFAw13gDp1JUPr+oLzmL415V2Uj5a8r9TQ3v S27yUBH1Lbu+olcDsu++GHSwYIDA1FcBEL/dbYgo0OcMuzqib3rz+L7eNZmWRoeuU377 bs2n/xEfZHAZPEztuzfGbx4KgM5GEc/gZ7mrq7/MvZTIl8cZAkKvFUFDRjEZTThl9mK3 kmp0tDtAqAH4Y/nuYHdk+HEiYVBKgDkgPzDEuO6ifOaotT3G8x/qB4FITcp5Kx8HG6Yg MzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=X7DWBcxQ3dg/kAzLTqAGXgHx+yLDtJdPTHYNmGO0asw=; b=YGCjJA8kv/BOBDOg569P4cJWK0enGA5n/IEnk8LXGSu9m0hcUTOTWyMue8SO9APmG4 F5DqF604tWa/+adFiUUBOKoCTyQmpp96Pjjn/CLrmvgjoUN/nQcqscjesqp1zH+7QCRu u2JfhqrT6sU8f7CYbUg2iiSYi4tV4xyQKn2te4xkLRQuXV2CJVzpb3A6Ayfeo+qDtJbL 0DSnRL0+xg1HGGx2ZkRN5s78D4ycmIuXXUE046L4zY1Y4F3n6+fAofVkBl1ILFxmmu0w B9/s+mx0zQf+5ZoqQAwgX1rdUWw1pbvfem+JjZvlpjt/yuu8aY2kB63ulcj3/0mgMRiH 0wQQ== X-Gm-Message-State: AOUpUlGoSJyoLHcckxtwtqxbKxh6WluJRelnj7BdMDLrslXATmDOEeUk A0vh5GEx8Jt3mGb5/cZ5fDLXI1pqX9k= X-Received: by 2002:a24:493:: with SMTP id 141-v6mr2499215itb.22.1533741414976; Wed, 08 Aug 2018 08:16:54 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id v3-v6sm2604880ita.6.2018.08.08.08.16.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 08:16:53 -0700 (PDT) Subject: Re: [PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive To: zhong jiang , jthumshirn@suse.de, martin.petersen@oracle.com Cc: linux-kernel@vger.kernel.org References: <1533740313-11906-1-git-send-email-zhongjiang@huawei.com> From: Jens Axboe Message-ID: Date: Wed, 8 Aug 2018 09:16:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1533740313-11906-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/8/18 8:58 AM, zhong jiang wrote: > debugfs_remove_recursive has taken null pointer into account. So it is > safe to drop the null check before calling the funtion. Applied, thanks. -- Jens Axboe