Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1000902imm; Wed, 8 Aug 2018 09:06:18 -0700 (PDT) X-Google-Smtp-Source: AA+uWPz174T4X/OdG4cIG/N80kYhAyKb7NBHW/EUe+isN0Xhhg6VXHe53AFeIWKZCLH6C3sS8V0O X-Received: by 2002:a63:4e25:: with SMTP id c37-v6mr3178041pgb.6.1533744377981; Wed, 08 Aug 2018 09:06:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533744377; cv=none; d=google.com; s=arc-20160816; b=HDumSmyYSm1IMtv6LhDb/x/Cvpy8b1GeMajKuG2DRP7WeFAVXIGZz07xOiB4qQNsEb +wcA5Zu3rU+z43qld/ZvOMUYczsj0RBEVUTLeWwyhuVgg8IgPImvnF5w6nMMSOo4ZL4+ 0PYXWxH8Z0rUzo95Yu/IeAlCCLxuYf1W8MRyKjgUe04/WldXRCA5BZUPAufd3aEZiNpu 8D4nkPdDUVnDpooRR23PUkaiA8OfaJ6RUAX0XdQ5zpESyqgooXSwIYjemsg8Yj0GF5h5 VXqGsCs0oQSqpzO5ELYDT3Y5eCkLUVCQaU6gGhqamrxm6MpEAo4CWcap/WYWQ8ZXp40I +TLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=L8DKoROSsOiUyNybow3fCKDivmCX773+Mpkg7vVOPms=; b=BwLgXTqol/uRZscI2PxlPfx2IhE60NPIGY30M1c/l37AEqh4Rr5IREAdz5IF/xPh2I RMzoGEw4b817bzATSvjEFwnFJ/BYLbtQeWaQRm4kQtk103U66iCkPTKKD7y+1r3amWFM CBhF21jbn+nAZ2JRrvR3oni5gvkEHh33O29k/1RHHUjXuhczRyKaLQakdKzngps8Rpmf CDOGQmiAAliKuqVVtPh3uZfF7hEwdYYy9KR6u1eyUey/VUgdD1sSYneDp5fK/uElSPgK d80iTfcTCse6nj4SJ1C3k4HVj0dsVVIRt4v9rQiPVD35bOWexXdyDIu1aTruex/+/msO OUJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aw2SSwnv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z77-v6si4712242pff.100.2018.08.08.09.06.02; Wed, 08 Aug 2018 09:06:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Aw2SSwnv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728024AbeHHSZQ (ORCPT + 99 others); Wed, 8 Aug 2018 14:25:16 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:42951 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727081AbeHHSZQ (ORCPT ); Wed, 8 Aug 2018 14:25:16 -0400 Received: by mail-io0-f195.google.com with SMTP id n18-v6so2220839ioa.9 for ; Wed, 08 Aug 2018 09:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L8DKoROSsOiUyNybow3fCKDivmCX773+Mpkg7vVOPms=; b=Aw2SSwnvvhUTBLSGOfmpfYV3LEWTRy6CdkgiiUv4bZIPh+R+kcQP3W2aOmbPxp+5z5 1fwZr9YJ48NPXCBtSRSx0j0bhvIfhK4U66UJHfkURQ3M5gl3ZNQAWIpw4QHvsv7R0Nry G2fy07ew4Nr+5W8nlCipj+/CaacH9Emu+jVfAhFpQtr+G+SpOc01UtxoUEtHw+WtUNDD 59SfrhGk9orFtECpCM3KYsvX8YeMYfzXQhDlWDo+naCifrrH4sjdu6UPkBK1rIqdI+E1 6NCx4Bsk213OZiBjOqC4iK5+5yRrFHidjF4Qe8b97R0CdBfu7AzIB/jvvzzYfFR4KHZG joYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L8DKoROSsOiUyNybow3fCKDivmCX773+Mpkg7vVOPms=; b=LA42JlUKYJlg2pk1RnlDKjM0IGqnaPp7eBCMmu11tZOo/rR0QzCa+ByB8qpV2hF3/y TErn5W1M3YLSLdXmqju14HUiVfrp7+odL3Azx80SDDRG4tIbYOqiZtZSjnLxqwecU7sc NvkncGt9o+d5jmR2xj3H515wKHZfJ3xqjHr0qnZw3R2yKtbb8I4AgdatYC4CbnL7Q51N 2KthhEFY7e82ldkHOqbAYa6CC4yBo3qELyobxhCR5YoFeD9L7ArpyvgRL6UH2vDnp1P2 ZGG19n/4i8tLxInfJ1nqsq0V5Olx19JPKxVeqUoN7vHB9oTH8NazESCfNG2UBeEKyxDO gOAA== X-Gm-Message-State: AOUpUlHnnOlVcodIhohilQWdSCkNJEw5x5vVsxZXjiZBf5kQCwfCBgAj TX5Oowzxw7ohSkfb7XVy3EZt1tSMnwM= X-Received: by 2002:a6b:b546:: with SMTP id e67-v6mr2878729iof.179.1533744295941; Wed, 08 Aug 2018 09:04:55 -0700 (PDT) Received: from [192.168.1.212] (107.191.0.158.static.utbb.net. [107.191.0.158]) by smtp.gmail.com with ESMTPSA id 82-v6sm2791977itm.2.2018.08.08.09.04.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 09:04:54 -0700 (PDT) Subject: Re: [PATCH] drivers/block/drbd: remove the null check for kmem_cache_destroy To: zhong jiang , lars.ellenberg@linbit.com Cc: linux-kernel@vger.kernel.org References: <1533741767-13055-1-git-send-email-zhongjiang@huawei.com> From: Jens Axboe Message-ID: Date: Wed, 8 Aug 2018 10:04:53 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <1533741767-13055-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/8/18 9:22 AM, zhong jiang wrote: > kmem_cache_destroy has taken null pointer into account. So it is > safe to drop the null check before calling the function. Applied, thanks. -- Jens Axboe