Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1192227imm; Wed, 8 Aug 2018 12:23:38 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyMetmYENbuEHjSjQNF/mkihZ3vjLck9OYgGsTtxhhTQsZN5nnqUuA5vH9SDw3pzO1eXu7Q X-Received: by 2002:a17:902:bd82:: with SMTP id q2-v6mr3730725pls.178.1533756217969; Wed, 08 Aug 2018 12:23:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533756217; cv=none; d=google.com; s=arc-20160816; b=zY1IfZGAj4a2ABdDTLNw3zbxHKvhT24wyAPAJXwVOAyk/3KMGrjMYQ2T3vowf3EOuY PTsVe+GFroEM2C0CZOk4W+Fm+Zz5IgOdNri8P+MsSbPm7+dAXE3PPl9YiQc8k7cUR9Id Q51Sv8mXxLASJ6HV0S26LnTgnT0sL2PKdlKv/bnSRvu90kMuix15UM+vuIMBPgQ0nnpN rCWf3U6y3zjF63/bDeoExdZbEUzqt9wz4hpHoSH/HhZ9bp9D5rCDpsl7egabR0J5PVGM wr4G5r1u0P/8l6E85SKylJ2QxARAoZJkoXnThgHSgyLS6FQT0/UHHLX4Hch0JWFzv75k dLZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=S6ppDBkZrdB2E4xJ3Wk5wRdbL2ME3tbm+Fzh3Id6uBg=; b=vz7XeLSN4+++2nCzRax5v5XtRBk29tJLjF6sch4iAyYMBcWBTFmi3fmCyxG7VQnoHv a2t49U3/sMmJYTjlcLx0yaqw//J4YAb1hRHHB7JnfZIp95ylGTYa8onL+Y14IRFa+cH1 nG+wlemB9wYJLYxLapigUldBRivHU2Qh3epnT8WbkY7HlmWJ8uttxfz8x5tO2OzR3NpH e09oDvH0zVp54pYiPj29wAj7GgzeCyCOS1vmVkvQd8iVCkfVIZrTE2Za/KhU4v6wQLkD X9hwfTtA2ztft0EdbJ4x8G4hRKJxhEResSUfN1xOgLCY5jsgat+OrUO1CTBMUrr0LGpk Iqhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si5266578pgr.260.2018.08.08.12.23.23; Wed, 08 Aug 2018 12:23:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731081AbeHHVnU (ORCPT + 99 others); Wed, 8 Aug 2018 17:43:20 -0400 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:29805 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727295AbeHHVm5 (ORCPT ); Wed, 8 Aug 2018 17:42:57 -0400 Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g4t3426.houston.hpe.com (Postfix) with ESMTP id D3AB960; Wed, 8 Aug 2018 19:21:51 +0000 (UTC) Received: from lxbuild.ftc.rdlabs.hpecorp.net (lxbuild.ftc.rdlabs.hpecorp.net [16.78.34.175]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id 7D79648; Wed, 8 Aug 2018 19:21:51 +0000 (UTC) From: Jerry Hoemann To: wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Jerry Hoemann Subject: [PATCH v2 2/5] watchdog: hpwdt: Claim NMI from iLO Date: Wed, 8 Aug 2018 13:13:24 -0600 Message-Id: <1533755607-71418-3-git-send-email-jerry.hoemann@hpe.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1533755607-71418-1-git-send-email-jerry.hoemann@hpe.com> References: <1533755607-71418-1-git-send-email-jerry.hoemann@hpe.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The hwpdt driver is overloaded for handling both the iLO watchdog and the explicit "Generate NMI to System" virutal button. Hence NMI handler needs to claim NMI resulting from the virutal button. Claim if iLO generated accommodating firmware that might set wrong bit. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index fae9364..bb41714 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -162,7 +162,7 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) if (ilo5 && ulReason == NMI_UNKNOWN && !mynmi) return NMI_DONE; - if (ilo5 && !pretimeout) + if (ilo5 && !pretimeout && !mynmi) return NMI_DONE; hpwdt_stop(); -- 1.8.3.1